Skip to content

Conversation

yyzxw
Copy link

@yyzxw yyzxw commented Aug 22, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:

add build-doc to release target ensure the API docs are up-to-date when releasing

Which issue(s) this PR fixes:
#1423

Fixes #

Does this PR introduce a user-facing change?:


@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 22, 2025
@k8s-ci-robot k8s-ci-robot requested a review from ahg-g August 22, 2025 02:14
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yyzxw
Once this PR has been reviewed and has the lgtm label, please assign arangogutierrez for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from kfswain August 22, 2025 02:14
@k8s-ci-robot
Copy link
Contributor

Welcome @yyzxw!

It looks like this is your first PR to kubernetes-sigs/gateway-api-inference-extension 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api-inference-extension has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 22, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @yyzxw. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

netlify bot commented Aug 22, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 07dc9ce
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68a7d29e9331cf0009274a95
😎 Deploy Preview https://deploy-preview-1431--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 22, 2025
@kfswain
Copy link
Collaborator

kfswain commented Aug 22, 2025

/ok-to-test

While tests run, just want to make sure we ran this to verify it works?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 22, 2025
@kfswain
Copy link
Collaborator

kfswain commented Aug 25, 2025

Actually, thinking about this more; the release runs on a release branch, while the docs for the website are all based on main. I'm not sure this is the way we want to handle this, we would need to update the release scripting.

@yyzxw
Copy link
Author

yyzxw commented Aug 26, 2025

Do we need different versions of the document? @kfswain

@danehans
Copy link
Contributor

danehans commented Sep 2, 2025

Until #422 is resolved, .github/ISSUE_TEMPLATE/new-release.md should be updated to state that apix-ref-docs and api-ref-docs should be run against the main branch so API docs are up-to-date (if needed) when publishing the release. @yyzxw if you have time, maybe you can work with @artberger to close out #422.

@ahg-g
Copy link
Contributor

ahg-g commented Sep 16, 2025

What is the status of this PR?

@yyzxw yyzxw closed this Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants