Skip to content

Conversation

chewong
Copy link
Member

@chewong chewong commented Aug 27, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Currently, users with an Istio Gateway must deploy a DestinationRule for each inference pool because, by default, EPP uses a self-signed certificate. This PR proposes adding the DestinationRule to the Helm Chart when .Values.provider.name is set to istio, similar to GKE's resources when provider is GKE and the DestinationRule deployed in the BBR Helm Chart here.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

helm: add Istio DestinationRule template for EPP service

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 27, 2025
Copy link

netlify bot commented Aug 27, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit d6df8de
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68af5783a5a17500089c155d
😎 Deploy Preview https://deploy-preview-1488--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chewong
Once this PR has been reviewed and has the lgtm label, please assign kfswain for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 27, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and danehans August 27, 2025 19:05
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 27, 2025
@chewong chewong force-pushed the epp-destination-rule branch from 7b588e9 to d6df8de Compare August 27, 2025 19:07
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 27, 2025
@Gregory-Pereira
Copy link

dupe of #1381, please let me know if I am missing anything in my implementation

@chewong
Copy link
Member Author

chewong commented Aug 28, 2025

Looks good! I will close this PR.

/close

@k8s-ci-robot
Copy link
Contributor

@chewong: Closed this PR.

In response to this:

Looks good! I will close this PR.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants