Skip to content

Conversation

learner0810
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Because the inferencepool resource has not been created yet, the ResolvedRefs conditions in the httproute status cannot be true,We should install inferencepool charts first and then check the status of httproute

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 4, 2025
Copy link

netlify bot commented Sep 4, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 84b1db6
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68b934e9b9660b000737b999
😎 Deploy Preview https://deploy-preview-1531--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: learner0810
Once this PR has been reviewed and has the lgtm label, please assign nirrozenbaum for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 4, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @learner0810. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 4, 2025
@nirrozenbaum
Copy link
Contributor

Hi @learner0810,
Thanks for your PR!

from my understanding seems like the problem that this PR is trying to address is that when http route is created the inference pool still doesn't exist and in order to fix it one should switch the creation order. is that correct?

please pay attention that we have an open PR #1524 that is about to get merged and is fixing this issue.

@learner0810
Copy link
Contributor Author

learner0810 commented Sep 4, 2025

Hi @learner0810, Thanks for your PR!

from my understanding seems like the problem that this PR is trying to address is that when http route is created the inference pool still doesn't exist and in order to fix it one should switch the creation order. is that correct?

please pay attention that we have an open PR #1524 that is about to get merged and is fixing this issue.

Sorry, I didn't notice that anyone had already submitted a pr

@learner0810 learner0810 closed this Sep 4, 2025
@learner0810 learner0810 deleted the fix-guides-index-md branch September 5, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants