Adds unit test to test CRDs

[bowei]

crdtest tests the current CRDs against example valid and invalid CRs. There
are two ways to use this:

Each test case takes its name from the name of the resource being
instantiated.

  - pkg/crdtest/valid are valid resource definitions.
  - pkg/crdtest/invalid are invalid resource definitions.

Run as a standard Go-test:

     $ go test ./pkg/crdtest

Run in -watch mode for development:

     $ go test -c -o crdtest ./pkg/crdtest # make crdtest
     $ ./crdtest -crdDir config/crd/standard -watch pkg/crdtest/valid 2>/tmp/out

will watch changes to the *.yaml files in pkg/crdtest/valid and attempt to
load them into an API server. Validation errors will be written to stdout.

Example output for -watch:

$ ./crdtest -crdDir config/crd/standard -watch pkg/crdtest/valid 2>/tmp/out

apiVersion: policy.networking.k8s.io/v1alpha2
kind: ClusterNetworkPolicy
metadata:
  name: cluster-wide-deny
spec:
  tier: Admin
  priority: 0
  subject:
    namespaces:
      matchLabels:
        kubernetes.io/metadata.name: sensitive-ns
  ingress:
    - action: Denyx
      name: select-all-deny-all
      from:
      - pods:
          namespaceSelector:
            matchLabels: {}
          podSelector:
            matchLabels: {}

❌ pkg/crdtest/valid/cluster-wide-deny.yaml: ClusterNetworkPolicy.policy.networking.k8s.io "cluster-wide-deny" is invalid: [spec.ingress[0].action: Unsupported value: "Denyx": supported values: "Accept", "Deny", "Pass", <nil>: Invalid value: null: some validation rules were not checked because the object was invalid; correct the existing errors to complete validation]
---
apiVersion: policy.networking.k8s.io/v1alpha2
kind: ClusterNetworkPolicy
metadata:
  name: cluster-wide-deny
spec:
  tier: Admin
  priority: 0
  subject:
    namespaces:
      matchLabels:
        kubernetes.io/metadata.name: sensitive-ns
  ingress:
    - action: Deny
      name: select-all-deny-all
      from:
      - pods:
          namespaceSelector:
            matchLabels: {}
          podSelector:
            matchLabels: {}

✅ pkg/crdtest/valid/cluster-wide-deny.yaml

[netlify]

✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!

Name	Link
🔨 Latest commit	0e627c4
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-network-policy-api/deploys/68fbff903324a7000811cac9
😎 Deploy Preview	https://deploy-preview-331--kubernetes-sigs-network-policy-api.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[bowei]

@robscott thanks for the idea

[robscott]

This is very cool, thanks @bowei! All credit to @rikatz for the improvements on GW API side.

[bowei]

/test

[k8s-ci-robot]

@bowei: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test pull-network-policy-api-crd-e2e

/test pull-network-policy-api-verify

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[bowei]

/test pull-network-policy-api-verify

[bowei]

@tssurya @npinaeva @danwinship -- any comments?

[rikatz]

somehow nit, but...

you have testify already on this repo, so maybe require.NoError(t, err) just to reduce the verbosity

(applies to all below, but instead of adding a require on the Create and delete you can do an assert so it wont leave the test)

[bowei]

This is the style recommended by the Go authors...

https://google.github.io/styleguide/go/decisions#assert

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bowei
Once this PR has been reviewed and has the lgtm label, please assign npinaeva for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[npinaeva]

nice automation!

[bowei]

I incorporated all of the comments.

[npinaeva]

so if Stop succeeds, you will continue to m.Run() and cleaning up test env again?
maybe you can just

if *watchDir != "" {
    watchAndTest(*watchDir)
    rc = 0 
} else {
    rc = m.Run()
}