Skip to content

chore: bump k8s to v1.33.0 #8116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

MenD32
Copy link

@MenD32 MenD32 commented May 10, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Bump k8s packages to v1.33.0, blocking autoscaler DRA issues.

Which issue(s) this PR fixes:

Fixes #
#8086

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MenD32
Once this PR has been reviewed and has the lgtm label, please assign bigdarkclown for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 10, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @MenD32. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 10, 2025
@k8s-ci-robot k8s-ci-robot added area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider area/provider/kwok Issues or PRs related to the kwok cloud provider for Cluster Autoscaler area/provider/oci Issues or PRs related to oci provider labels May 10, 2025
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 10, 2025
@MenD32
Copy link
Author

MenD32 commented May 10, 2025

There are 2 different things that need to change in order for this to work:

  1. ResourceSliceTracker interface has changed from List() -> ListWithDeviceTaints()
  2. go bumped to 1.24, which causes format functions with non-constant format string to fail compile (most of the changes)

The format string change is mostly replace macros, for example:

return true, fmt.Errorf(strings.Join(errMessage, "\n")) -> return true, fmt.Errorf("%s", strings.Join(errMessage, "\n"))

specifically the replace function above will do most of the changes needed to upgrade go to v1.24

@MenD32
Copy link
Author

MenD32 commented May 11, 2025

the go 1.24.0 bump is already implemented in #8117

@MenD32 MenD32 closed this May 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider area/provider/huaweicloud area/provider/kwok Issues or PRs related to the kwok cloud provider for Cluster Autoscaler area/provider/oci Issues or PRs related to oci provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants