-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Fixes multiple cluster autoscaler with different configmap, lease and release name #8336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Welcome @michael-act! |
Hi @michael-act. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: michael-act The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e1b7227
to
6817b6c
Compare
Error CI:
Do I need to bump it manually? |
609c95c
to
b72f5c0
Compare
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes a bug in the Helm template where multiple Cluster Autoscalers deployed in the same namespace could not coexist due to conflicting configmap and lease.
Example Values
Example Release
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
configmap
,leases
, etc.)Does this PR introduce a user-facing change?
No.
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
None.