Skip to content

CA: add elmiko as maintainer #8376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jackfrancis
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR officially gives @elmiko the ability to review and approve Cluster Autoscaler changes, which recognizes his existing contributions and will help project velocity.

He has landed over 40 PRs over the last 5+ years and is a consistent fixture in the SIG:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area labels Jul 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-area labels Jul 28, 2025
@jackfrancis
Copy link
Contributor Author

@elmiko
Copy link
Contributor

elmiko commented Jul 28, 2025

it's an honor just to be nominated =)

@towca
Copy link
Collaborator

towca commented Jul 28, 2025

A big +1 for the nomination from me, @elmiko has been a very active member of the community for a long time and has demonstrated deep Cluster Autoscaler knowledge.

There are formal k8s requirements for the Reviewer/Approver roles: https://github.com/kubernetes/community/blob/master/community-membership.md#approver. Most of them seem to be satisfied here, but these stand out:

  • "Primary reviewer for at least 10 substantial PRs to the codebase" I'm not sure how to validate that, any chance you could come up with a list Michael?
  • "Reviewer of the codebase for at least 3 months" It seems like there is a mandated Reviewer->Approver progression, so we need to start with Reviewer here.

@jackfrancis
Copy link
Contributor Author

A big +1 for the nomination from me, @elmiko has been a very active member of the community for a long time and has demonstrated deep Cluster Autoscaler knowledge.

There are formal k8s requirements for the Reviewer/Approver roles: https://github.com/kubernetes/community/blob/master/community-membership.md#approver. Most of them seem to be satisfied here, but these stand out:

  • "Primary reviewer for at least 10 substantial PRs to the codebase" I'm not sure how to validate that, any chance you could come up with a list Michael?
  • "Reviewer of the codebase for at least 3 months" It seems like there is a mandated Reviewer->Approver progression, so we need to start with Reviewer here.

@towca Done

@jackfrancis
Copy link
Contributor Author

/hold

to give some time for other maintainers to weigh in

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2025
@elmiko
Copy link
Contributor

elmiko commented Jul 29, 2025

"Primary reviewer for at least 10 substantial PRs to the codebase" I'm not sure how to validate that, any chance you could come up with a list Michael?

looks like i've participated in 109 closed reviews

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants