-
Notifications
You must be signed in to change notification settings - Fork 4.2k
CA: add elmiko as maintainer #8376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
it's an honor just to be nominated =) |
A big +1 for the nomination from me, @elmiko has been a very active member of the community for a long time and has demonstrated deep Cluster Autoscaler knowledge. There are formal k8s requirements for the Reviewer/Approver roles: https://github.com/kubernetes/community/blob/master/community-membership.md#approver. Most of them seem to be satisfied here, but these stand out:
|
@towca Done |
/hold to give some time for other maintainers to weigh in |
looks like i've participated in 109 closed reviews |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR officially gives @elmiko the ability to review and approve Cluster Autoscaler changes, which recognizes his existing contributions and will help project velocity.
He has landed over 40 PRs over the last 5+ years and is a consistent fixture in the SIG:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: