-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(chart): add PodDisruptionBudget chart for admission controller #8642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(chart): add PodDisruptionBudget chart for admission controller #8642
Conversation
|
Welcome @itstrueitstrueitsrealitsreal! |
Hi @itstrueitstrueitsrealitsreal. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: itstrueitstrueitsrealitsreal The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
47f828c
to
0636acd
Compare
0636acd
to
18ae140
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
Overall lgtm ( left one comment there ).
/ok-to-test |
18ae140
to
01b4104
Compare
Sorry for this, but can you pause this while we get #8617 merged? |
Sure, no worries |
01b4104
to
c97c26b
Compare
Change-Id: If7b508b8890387609f514a2c8e72ffa809b9d90c
c97c26b
to
e8be1d0
Compare
/hold |
Change-Id: If7b508b8890387609f514a2c8e72ffa809b9d90c
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds PodDisruptionBudget support to the VPA admission controller Helm chart.
Which issue(s) this PR fixes:
Part of #8587
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: