-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Add graduation criteria for CapacityBuffers. #8886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jbtk
wants to merge
1
commit into
kubernetes:master
Choose a base branch
from
jbtk:buffers-beta
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+24
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,30 @@ | |
|
|
||
| #### Author: Justyna Betkier (jbtk) | ||
|
|
||
| # Timeline | ||
|
|
||
| ## Alpha (launched to 1.34) | ||
|
|
||
| - [x] Implement the API definition | ||
| - [x] Implement the buffer controller and fake pod processing logic in the cluster autoscaler | ||
|
|
||
| ## Beta graduation criteria (planned for 1.35) | ||
|
|
||
| - [ ] Implement integration with k8s resource quotas | ||
|
|
||
| ## V1 graduation criteria (planned for TBD) | ||
|
|
||
| - [ ] E2e test implemented and healthy | ||
| - [ ] In beta for at least 1 full version | ||
| - [ ] Waiting up to 2 versions in beta for second OSS implementation | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So you'd target 1.37. While I fully expect us to come to a decision before then, I'd hope we could have a conversation rather than falling back to lazy consensus. |
||
| (karpenter). In case of no implementation in order to avoid permanent beta | ||
| (following the spirit of [guidance for k8s REST APIs](https://kubernetes.io/blog/2020/08/21/moving-forward-from-beta/#avoiding-permanent-beta)) | ||
| we will reevaluate the graduation criteria with sig-autoscaling leads based on: | ||
| - existing adoption and feedback | ||
| - reasons for no implementation and immediate future plans | ||
| - [ ] Graduation plan announced 1 month in advance on sig-autoscaling meeting to allow time for feedback | ||
| - [ ] Reviewed and summarized all open issues about buffers in the https://github.com/kubernetes/autoscaler/ repository | ||
|
|
||
| # Summary | ||
|
|
||
| If the user uses autoscaling the cluster size will be adjusted to the number of | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't 1.35 more or less closed at this point? I thought it was launching very soon.