Skip to content

Conversation

mgfritch
Copy link
Contributor

@mgfritch mgfritch commented Oct 10, 2025

Follow-up to #706 (comment)

Changes

  • Remove explicit pin to k8s v1.30.12
  • Update dependencies to k8s v1.34.1
  • Update to coredns v1.13.1
  • Update to go 1.24

Validation

make all && make test

- Remove explicit pin to k8s v1.30.12
- Update dependencies to k8s v1.34.1
- Update to coredns v1.13.1
- Update to go 1.24

Signed-off-by: Michael Fritch <[email protected]>
Copy link

linux-foundation-easycla bot commented Oct 10, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mgfritch / name: Michael Fritch (aba3ced)

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 10, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @mgfritch!

It looks like this is your first PR to kubernetes/dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @mgfritch. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 10, 2025
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 10, 2025
Copy link
Collaborator

@DamianSawicki DamianSawicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 14, 2025
@DamianSawicki
Copy link
Collaborator

/retest

Michcioperz added a commit to Michcioperz/k8s-dns that referenced this pull request Oct 14, 2025
Automated findings that lead me to make these bumps include:
CVE-2025-4802, CVE-2025-9230, CVE-2025-9232, CVE-2025-8058

Additionally, distroless-iptables image is upgraded to its go1.24
variant to match the bump in Go version in kubernetes#722
Michcioperz added a commit to Michcioperz/k8s-dns that referenced this pull request Oct 14, 2025
Automated findings that lead me to make these bumps include:
CVE-2025-4802, CVE-2025-9230, CVE-2025-9232, CVE-2025-8058

Additionally, distroless-iptables image is upgraded to its go1.24
variant to match the bump in Go version in kubernetes#722

Upload dates are removed as half the time we forget to update them.
@Michcioperz Michcioperz mentioned this pull request Oct 14, 2025
Copy link
Collaborator

@DamianSawicki DamianSawicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DamianSawicki, mgfritch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit ac6de63 into kubernetes:master Oct 14, 2025
3 checks passed
Michcioperz added a commit to Michcioperz/k8s-dns that referenced this pull request Oct 14, 2025
Automated findings that lead me to make these bumps include:
CVE-2025-4802, CVE-2025-9230, CVE-2025-9232, CVE-2025-8058

Additionally, distroless-iptables image is upgraded to its go1.24
variant to match the bump in Go version in kubernetes#722

Upload dates are removed as half the time we forget to update them.

Apparently kube-cross image has moved years ago to a /build-image/
subpath: I couldn't figure it out until I found
https://github.com/kubernetes/kubernetes/blob/9b9cd768a05782b6cfeef62bec7696b441d7ad93/build/pause/Makefile#L50

Also using this opportunity to leave breadcrumbs where to find the newer
images.
Michcioperz added a commit to Michcioperz/k8s-dns that referenced this pull request Oct 14, 2025
Automated findings that lead me to make these bumps include:
CVE-2025-4802, CVE-2025-9230, CVE-2025-9232, CVE-2025-8058

Additionally, distroless-iptables image is upgraded to its go1.24
variant to match the bump in Go version in kubernetes#722

Upload dates are removed as half the time we forget to update them.

Apparently kube-cross image has moved years ago to a /build-image/
subpath: I couldn't figure it out until I found
https://github.com/kubernetes/kubernetes/blob/9b9cd768a05782b6cfeef62bec7696b441d7ad93/build/pause/Makefile#L50

Also using this opportunity to leave breadcrumbs where to find the newer
images.
Michcioperz added a commit to Michcioperz/k8s-dns that referenced this pull request Oct 14, 2025
Automated findings that lead me to make these bumps include:
CVE-2025-4802, CVE-2025-9230, CVE-2025-9232, CVE-2025-8058

Additionally, distroless-iptables image is upgraded to its go1.24
variant to match the bump in Go version in kubernetes#722

Upload dates are removed as half the time we forget to update them.

Apparently kube-cross image has moved years ago to a /build-image/
subpath: I couldn't figure it out until I found
https://github.com/kubernetes/kubernetes/blob/9b9cd768a05782b6cfeef62bec7696b441d7ad93/build/pause/Makefile#L50

Also using this opportunity to leave breadcrumbs where to find the newer
images.
@mgfritch mgfritch deleted the coredns-1.13.1 branch October 15, 2025 02:08
@mgfritch
Copy link
Contributor Author

@DamianSawicki Any chance we will see a new tag for this soon?

We'd like to include these into our next downstream release. Thanks!

@DamianSawicki
Copy link
Collaborator

@DamianSawicki Any chance we will see a new tag for this soon?

We'd like to include these into our next downstream release. Thanks!

Sure, I've just cut https://github.com/kubernetes/dns/releases/tag/1.26.6 (@Michcioperz FYI), which is step 6 of https://github.com/kubernetes/dns?tab=readme-ov-file#release-process. If needed, feel free to prepare PRs for the remaining steps.

@DamianSawicki
Copy link
Collaborator

Actually, I've just cut https://github.com/kubernetes/dns/releases/tag/1.26.7 as well, so it's better to use the latter.

@mgfritch
Copy link
Contributor Author

Thanks! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants