Skip to content

Conversation

@thockin
Copy link
Member

@thockin thockin commented Sep 8, 2025

Bookworm is currently "oldstable", Trixie is "stable".

https://security-tracker.debian.org/tracker/CVE-2025-48384 is fixed in Trixie but not Bookworm, and it seems likely that more CVEs will come and fit the same pattern.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 8, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 8, 2025
@thockin
Copy link
Member Author

thockin commented Sep 8, 2025

@BenTheElder objections?

Dockerfile.in Outdated
RUN apt-get -y -qq -o Dpkg::Use-Pty=0 -y upgrade

RUN apt-get -y -qq -o Dpkg::Use-Pty=0 install --no-install-recommends bash # for the staging scripts and ldd
# Newer Debian uses symlinks but the stage_binaries tool is kind of dumb.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, we should be able to fix that, and we'll probably run into this again?

we have a couple divergent copies, kind, here, kubernetes/release (k/k base images)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the meantime - any objection to using Trixie?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the build still have portability with bookworm? My main concern is around compatibility with the GKE debian-base image, which to my understanding is currently still on bookworm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the meantime - any objection to using Trixie?

I don't personally, Kubernetes core will be slow to move our base images because of glibc compat with binaries running on the host (IE kubelet) but I don't think git-sync needs to.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdowell - bookworm is so old that CVEs are either not going to be fixed or are taking an especially long time (https://security-tracker.debian.org/tracker/CVE-2025-48384).

I'm not trying to make work, but a build on Bookworm has a 2 month old "HIGH" CVE. This is only going to get worse. I just ran a build on bookworm, knowing that it doesn't fix the CVE, and it DOES build.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack sounds good, we can always tweak the internal git-sync build tooling if needed - but ideally it can build without significant modifications to the upstream tooling. Perhaps an action item can be to follow up with the maintainers of GKE debian-base and see if it can be updated to trixie

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it passes tests

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 10, 2025
Also delete some more cruft to make the image a bit smaller
@thockin
Copy link
Member Author

thockin commented Sep 10, 2025

AFAICT this PR is "done" and ok to review.

Copy link
Contributor

@sdowell sdowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdowell, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d499de1 into kubernetes:master Sep 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants