Skip to content

add karpenter cluster api staging registry #8557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2025
Merged

add karpenter cluster api staging registry #8557

merged 1 commit into from
Oct 27, 2025
+61 −0

Conversation

@elmiko
Copy link
Contributor

@elmiko elmiko commented Sep 24, 2025

following up from the creation of the karpenter cluster-api group, this change adds the registry files for the controller.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 24, 2025
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/infra Infrastructure management, infrastructure design, code in infra/ size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/registry.k8s.io Code in registry.k8s.io/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Sep 24, 2025
@elmiko
Copy link
Contributor Author

elmiko commented Sep 24, 2025

@ameukam i followed the example from #8448, but i wasn't sure about the promoter manifest. happy to fix this up as necessary.

@elmiko
Copy link
Contributor Author

elmiko commented Sep 24, 2025

for reference, previous PR #8495

@ameukam
Copy link
Member

ameukam commented Sep 24, 2025

You can put something like:

# No images yet

in registry.k8s.io/images/k8s-staging-karpenter-cluster-api/images.yaml so the image promoter will not attempt to promote an empty file.

@elmiko elmiko mentioned this pull request Sep 25, 2025
Open
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2025
@elmiko
Copy link
Contributor Author

elmiko commented Sep 25, 2025

updated with @ameukam 's suggestion.

once the registry is created, is there some documentation or an example of how we add images?

@ameukam
Copy link
Member

ameukam commented Sep 29, 2025

The manifest's path is missing in ./registry.k8s.io/manifests.

@ameukam
Copy link
Member

ameukam commented Sep 29, 2025

atlantis plan

@k8s-infra-ci-robot
Copy link
Contributor

Ran Plan for dir: infra/gcp/terraform/k8s-staging-images workspace: default

Plan Failed: This project is currently locked by an unapplied plan from pull #8565. To continue, delete the lock from #8565 or apply that plan and merge the pull request.

Once the lock is released, comment atlantis plan here to re-plan.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 29, 2025
@elmiko
Copy link
Contributor Author

elmiko commented Sep 29, 2025

@ameukam , i added the manifest directory and copied the promoter file from cluster-api with modifications for the karpenter names. i hope i did that correctly XD

ameukam
ameukam reviewed Oct 1, 2025
View reviewed changes
registry.k8s.io/manifests/k8s-staging-karpenter-cluster-api/promoter-manifest.yaml
- name: us-west1-docker.pkg.dev/k8s-artifacts-prod/images/karpenter-cluster-api
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
- name: us-west2-docker.pkg.dev/k8s-artifacts-prod/images/karpenter-cluster-api
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
service-account: k8s-infra-gcr-promoter@k8s-artifacts-prod.iam.gserviceaccount.com
imagesPath: "../../images/k8s-staging-karpenter-cluster-api/images.yaml"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated with suggestion

@elmiko
Copy link
Contributor Author

elmiko commented Oct 7, 2025

not sure if the current error is related to my changes, it isn't obvious to me from the logs.

@ameukam
Copy link
Member

ameukam commented Oct 14, 2025

/retest

1 similar comment
@ameukam
Copy link
Member

ameukam commented Oct 17, 2025

/retest

@elmiko
Copy link
Contributor Author

elmiko commented Oct 27, 2025

@ameukam is this an error that i've created? just curious if it's something i can resolve.

@ameukam
Copy link
Member

ameukam commented Oct 27, 2025

@ameukam is this an error that i've created? just curious if it's something i can resolve.

The issue is not on the PR. We are dealing with a side effect of the migration effort for GCR to Artifact Registry

@ameukam
Copy link
Member

ameukam commented Oct 27, 2025

/test pull-k8sio-cip

@ameukam
Copy link
Member

ameukam commented Oct 27, 2025

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, elmiko, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9f32c5f into kubernetes:main Oct 27, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Oct 27, 2025
@elmiko elmiko deleted the karp-capi-reg branch October 27, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ameukam ameukam ameukam left review comments

@dims dims Awaiting requested review from dims

@upodroid upodroid Awaiting requested review from upodroid

+1 more reviewer

@justinsb justinsb justinsb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@justinsb justinsb

@ameukam ameukam

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ area/registry.k8s.io Code in registry.k8s.io/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.35

Development

Successfully merging this pull request may close these issues.

5 participants

@elmiko @ameukam @k8s-infra-ci-robot @k8s-ci-robot @justinsb