-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix: fix node-local-dns on cilium 1.16.5+ #17484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi @rsafonseca. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Looks like there's a valid test failure, will look into it in the morning :) |
/retest |
Signed-off-by: Rafael da Fonseca <[email protected]>
37606d4
to
63de898
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4ba9373
to
a3c5aeb
Compare
Signed-off-by: Rafael da Fonseca <[email protected]>
a3c5aeb
to
5d507a3
Compare
fixes node-local-dns when BPF host networking is enabled on cilium 1.16.5+
The config change should automatically enable when
cluster.spec.networking.cilium
is specifiedThe config change should also enable when
cluster.Spec.KubeDNS.NodeLocalDNS.CiliumBPFCompatibility
is explicitly set to true, which is needed when users are managing cilium on their on viacluster.spec.networking.cni: {}
When applying onto an existing cluster, the nodes will need to be rolled out to recreate the node-local-dns pod, as well as update the dns resolver address that is being passed explicitly to kubelet. Once rollout of existing nodes is finished, it should be safe to upgrade cilium with BPF host networking enabled
fixes: #16597