Skip to content

fix: fix node-local-dns on cilium 1.16.5+ #17484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rsafonseca
Copy link
Contributor

@rsafonseca rsafonseca commented Jul 10, 2025

fixes node-local-dns when BPF host networking is enabled on cilium 1.16.5+

The config change should automatically enable when cluster.spec.networking.cilium is specified
The config change should also enable when cluster.Spec.KubeDNS.NodeLocalDNS.CiliumBPFCompatibility is explicitly set to true, which is needed when users are managing cilium on their on via cluster.spec.networking.cni: {}

When applying onto an existing cluster, the nodes will need to be rolled out to recreate the node-local-dns pod, as well as update the dns resolver address that is being passed explicitly to kubelet. Once rollout of existing nodes is finished, it should be safe to upgrade cilium with BPF host networking enabled

fixes: #16597

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 10, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @rsafonseca. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hakman
Copy link
Member

hakman commented Jul 10, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2025
@rsafonseca
Copy link
Contributor Author

Looks like there's a valid test failure, will look into it in the morning :)

@hakman
Copy link
Member

hakman commented Jul 11, 2025

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hakman. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 11, 2025
@rsafonseca rsafonseca force-pushed the fix_nodelocaldns branch 3 times, most recently from 4ba9373 to a3c5aeb Compare July 11, 2025 11:48
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 11, 2025
Signed-off-by: Rafael da Fonseca <[email protected]>
@rsafonseca rsafonseca requested a review from hakman July 11, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/addons area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node-local-dns doesn't work with cilium CNI on kops 1.29.0
3 participants