kubetest2-kops: drop gsutil for GCS bucket lifecycle #17699
Conversation
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-kops-kubernetes-e2e-ubuntu-gce-build |
ameukam
force-pushed
the
kubetest2-kops-stop-use-gsutil
branch
from
e474c22 to
5cae033
Compare
|
/test pull-kops-kubernetes-e2e-ubuntu-gce-build |
|
@ameukam: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Use GCS Go SDK to operate the state and discovery buckets Signed-off-by: Arnaud Meukam <[email protected]>
Signed-off-by: Arnaud Meukam <[email protected]>
ameukam
force-pushed
the
kubetest2-kops-stop-use-gsutil
branch
from
5cae033 to
8e38ca7
Compare
| } | ||
| if projectID != "" { | ||
| lsArgs = append(lsArgs, "-p", projectID) | ||
| // TODO: Detect the GCP region used |
There was a problem hiding this comment.
Suggestion: mark EnsureGCSBucket as deprecated, if you don't want to just add region as an argument to EnsureGCSBucket
| } | ||
|
|
||
| func EnsureGCSBucketWithRegion(bucketPath, projectID string, region string, public bool) error { | ||
| ctx := context.Background() |
There was a problem hiding this comment.
Nit: if I'm adding arguments I would probably add ctx as an argument while I'm here
| } | ||
| if projectID != "" { | ||
| mbArgs = append(mbArgs, "-p", projectID) | ||
| // If error is not "bucket doesn't exist", return error |
4 participants
Use GCS Go SDK to operate the state and discovery buckets
Signed-off-by: Arnaud Meukam [email protected]