Skip to content

docs: Update krunkit.md with latest installation instructions#23176

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
JoKrefting:patch-1
Jun 28, 2026
Merged

docs: Update krunkit.md with latest installation instructions#23176
kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
JoKrefting:patch-1

Conversation

@JoKrefting

Copy link
Copy Markdown
Contributor

Replace deprecated installation instructions with new tap slp/krun and note about how to uninstall previous tap.

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JoKrefting
Once this PR has been reviewed and has the lgtm label, please assign nirs for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jun 19, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: JoKrefting / name: JoKrefting (c37a342)

@k8s-ci-robot k8s-ci-robot requested a review from nirs June 19, 2026 07:40
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Welcome @JoKrefting!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 19, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @JoKrefting. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@minikube-bot

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 19, 2026
Comment thread site/content/en/docs/drivers/krunkit.md Outdated
Comment thread site/content/en/docs/drivers/krunkit.md Outdated
Comment thread site/content/en/docs/drivers/krunkit.md Outdated

@nirs nirs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pleas squash the commits - there is no reason to have more than one commit for this change.

Comment thread site/content/en/docs/drivers/krunkit.md Outdated
Comment thread site/content/en/docs/drivers/krunkit.md Outdated
@nirs nirs added this to the minikube v1.39 milestone Jun 27, 2026
Replace deprecated installation instructions with new tap slp/krun

@nirs nirs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoKrefting Thanks!

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2026
@nirs

nirs commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

/lgtm

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoKrefting, nirs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow

kubernetes-prow Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

@JoKrefting: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-minikube-docker-crio-linux-x86 abaa2e7 link false /test pull-minikube-docker-crio-linux-x86
pull-minikube-docker-containerd-linux-arm abaa2e7 link false /test pull-minikube-docker-containerd-linux-arm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nirs

nirs commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

/retest-required

@kubernetes-prow kubernetes-prow Bot merged commit e0f77e5 into kubernetes:master Jun 28, 2026
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants