Skip to content

Fix for the coredns configmap update: the corefile was not updated, e… #3378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for the coredns configmap update: the corefile was not updated, e… #3378

wants to merge 2 commits into from

Conversation

Tanzp01
Copy link

@Tanzp01 Tanzp01 commented Jun 6, 2025 •
edited
Loading

What type of PR is this?

Fix for bug

What this PR does / why we need it:

This change should fix the coredns configmap update, and enable the test can also be run on python3.

Which issue(s) this PR fixes:

Fixes - When test GKE DNS performance with the auto creation of dns-perf-server, the coredns configmap corefile was not updated even if different cache size was set as parameters.

Special notes for your reviewer:

@Tanzp01
Fix for the coredns configmap update: the corefile was not updated, e…
aa88a63 
…ven though a different cache size is set up in the test parameters.
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jun 6, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 6, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @Tanzp01!

It looks like this is your first PR to kubernetes/perf-tests 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/perf-tests has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Tanzp01
Once this PR has been reviewed and has the lgtm label, please assign dlapcevic for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @Tanzp01. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 6, 2025
@bowei
Copy link
Member

bowei commented Jun 18, 2025

You need to do the EasyCLA.

@bowei
Copy link
Member

bowei commented Jun 18, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 18, 2025
@Tanzp01
Copy link
Author

Tanzp01 commented Jun 20, 2025

Hi, I have updated the necessary CLA, could you take a look?

bowei
bowei reviewed Aug 6, 2025
View reviewed changes
dns/py/params.py Outdated
if value > 0:
cf = inputs.configmap_yaml['data']['Corefile']
cfList = cf.decode().split("\n")
# fix the cf type so that it works also for python3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we just update the code for Python 3? Isn't Python 2 deprecated?

Copy link
Author

@Tanzp01 Tanzp01 Aug 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bowei for the feedbacks! I have removed the line for python2, now only python3 supported for cleaner code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei left review comments

@jprzychodzen jprzychodzen Awaiting requested review from jprzychodzen

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tanzp01 @k8s-ci-robot @bowei