Skip to content

Conversation

@nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Oct 16, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR reverts #3436 which seems like the most likely reason why https://perf-dash.k8s.io/ looks broken at the moment:
image

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 16, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 16, 2025
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Oct 16, 2025

/assign @wojtek-t

@wojtek-t
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit d56050b into kubernetes:master Oct 17, 2025
5 checks passed
@nojnhuh nojnhuh deleted the revert-dra branch October 17, 2025 15:30
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Oct 17, 2025

@wojtek-t Are there any logs I can check to see why this might've broken things? I tried running perf-dash locally but couldn't reproduce this exact issue when I point to the same githubConfigDirs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants