Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ip ranges for Q1 2025 #301

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Feb 6, 2025

It has been a while since we updated the IP ranges #288

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 6, 2025
@k8s-ci-robot k8s-ci-robot requested review from hh and thockin February 6, 2025 19:09
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 6, 2025
@upodroid upodroid force-pushed the update-ip-ranges-q1-2025 branch from 11260b1 to d4fe979 Compare February 6, 2025 19:22
@dims
Copy link
Member

dims commented Feb 6, 2025

aws-ip-ranges.json is impossible to review! 🙃

/approve
/lgtm

/hold until we need to merge!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2025
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 6, 2025
@BenTheElder
Copy link
Member

aws-ip-ranges.json is impossible to review! 🙃

you could diff it versus the upstream source, we could try to enforce that but it's difficult because we don't want CI to break everytime there's new data.

I primarily look to see that it looks like valid data, the actual values at worst would just make us less efficient if they're wrong (e.g. if there was a block covering the entire IP space to one vendor)

The generated code file I believe we already lint verify, but otherwise we just want to look for malicious init type behavior right?

Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@BenTheElder
Copy link
Member

At some point we might consider further optimizing the data load and lookup but ... so far it's YAGNI. Last I checked the request logs cost more than the cloud run compute and our responses are pretty fast.

@upodroid
Copy link
Member Author

upodroid commented Feb 6, 2025

I'll cancel the hold after I verify #300 works

Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims, upodroid, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@upodroid
Copy link
Member Author

upodroid commented Feb 7, 2025

/hold cancel

autodeploy works

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit 4eed00d into kubernetes:main Feb 7, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants