-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ip ranges for Q1 2025 #301
Update ip ranges for Q1 2025 #301
Conversation
11260b1
to
d4fe979
Compare
aws-ip-ranges.json is impossible to review! 🙃 /approve /hold until we need to merge! |
you could diff it versus the upstream source, we could try to enforce that but it's difficult because we don't want CI to break everytime there's new data. I primarily look to see that it looks like valid data, the actual values at worst would just make us less efficient if they're wrong (e.g. if there was a block covering the entire IP space to one vendor) The generated code file I believe we already lint verify, but otherwise we just want to look for malicious init type behavior right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
At some point we might consider further optimizing the data load and lookup but ... so far it's YAGNI. Last I checked the request logs cost more than the cloud run compute and our responses are pretty fast. |
I'll cancel the hold after I verify #300 works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, dims, upodroid, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel autodeploy works |
It has been a while since we updated the IP ranges #288