-
Notifications
You must be signed in to change notification settings - Fork 426
Add Comms progress tracking issue template, adjust Release Highlight template #2792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Comms progress tracking issue template, adjust Release Highlight template #2792
Conversation
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/assign @katcosgrove |
Double checking @rytswd Otherwise, we could hold off as I imagine shadows are reading the handbook soon. (could add some confusion) |
We would probably want to update a bit as this was not fully done. I'm sure @aibarbetta has more to add. |
364cc8c
to
1871f0d
Compare
/retitle Add Comms progress tracking issue template, adjust Release Highlight template |
@aibarbetta @graz-dev So long overdue, but here is the quick template update from my end. It would be great if you could take a look and see if it would make sense to get these template updates in place, or simply keep it as is. CC @drewhagen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I left some nits
release-team/role-handbooks/communications/templates/progress-tracking-issue.md
Outdated
Show resolved
Hide resolved
release-team/role-handbooks/communications/templates/progress-tracking-issue.md
Show resolved
Hide resolved
release-team/role-handbooks/communications/templates/progress-tracking-issue.md
Outdated
Show resolved
Hide resolved
|
||
## Other Follow-up Actions and Notes | ||
|
||
- We should make clarification on when the Feature Blog opt-in reach-outs to happen (it was a bit vague) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use the same clarification as the Release Highlights:
With Enhancement freeze in effect (in week 5), start the Feature Blog opt-in reach-outs
We did that for v1.34 and it gave us some time to do a second reminder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by this exactly? You mean there should be a clear note about the Feature Blog opt-in reminder to take place right after enhancement freeze, so something around line#133?
- Make sure all the templates use the consistent KEP referencing of something like: `[KEP-4974: Deprecate v1.Endpoints](https://kep.k8s.io/4974)` | ||
- Document the version should be "v" prefixed | ||
- Update the blog status field to prefix with some numbers (the current "ready for review", "review in progress", "ready to publish" are all so similar and hard to see which one's which...) | ||
- When getting the placeholder blog PRs for Feature Blogs, we will need to get the KEP authors to come back to us in the KEP. There were a few blogs I only caught by going through the list of blog PRs, and it was quite manual. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good points, but I'm not sure they belong in this template. Perhaps we could move them to a Debt/Suggestions
section in release-team/role-handbooks/communications/README.md
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can mention in the PR description for future enhancements, but drop all of these comments from the template. I'll get to that in a bit.
- Make sure all the templates use the consistent KEP referencing of something like: `[KEP-4974: Deprecate v1.Endpoints](https://kep.k8s.io/4974)` | ||
- Document the version should be "v" prefixed | ||
- Update the blog status field to prefix with some numbers (the current "ready for review", "review in progress", "ready to publish" are all so similar and hard to see which one's which...) | ||
- When getting the placeholder blog PRs for Feature Blogs, we will need to get the KEP authors to come back to us in the KEP. There were a few blogs I only caught by going through the list of blog PRs, and it was quite manual. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- When getting the placeholder blog PRs for Feature Blogs, we will need to get the KEP authors to come back to us in the KEP. There were a few blogs I only caught by going through the list of blog PRs, and it was quite manual. | |
- When getting the placeholder blog PRs for Feature Blogs, we will need to get the KEP authors to come back to us in the KEP. Additionally, monitor https://github.com/kubernetes/website/pulls on Feature Blog opt-in season, check with the author and use labels `sig/release` and `area/blog` to keep track of them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you meant by "season" here -- is that potentially a typo?
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aibarbetta, rytswd The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review! Just left a few comments
- Make sure all the templates use the consistent KEP referencing of something like: `[KEP-4974: Deprecate v1.Endpoints](https://kep.k8s.io/4974)` | ||
- Document the version should be "v" prefixed | ||
- Update the blog status field to prefix with some numbers (the current "ready for review", "review in progress", "ready to publish" are all so similar and hard to see which one's which...) | ||
- When getting the placeholder blog PRs for Feature Blogs, we will need to get the KEP authors to come back to us in the KEP. There were a few blogs I only caught by going through the list of blog PRs, and it was quite manual. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can mention in the PR description for future enhancements, but drop all of these comments from the template. I'll get to that in a bit.
- Make sure all the templates use the consistent KEP referencing of something like: `[KEP-4974: Deprecate v1.Endpoints](https://kep.k8s.io/4974)` | ||
- Document the version should be "v" prefixed | ||
- Update the blog status field to prefix with some numbers (the current "ready for review", "review in progress", "ready to publish" are all so similar and hard to see which one's which...) | ||
- When getting the placeholder blog PRs for Feature Blogs, we will need to get the KEP authors to come back to us in the KEP. There were a few blogs I only caught by going through the list of blog PRs, and it was quite manual. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you meant by "season" here -- is that potentially a typo?
|
||
## Other Follow-up Actions and Notes | ||
|
||
- We should make clarification on when the Feature Blog opt-in reach-outs to happen (it was a bit vague) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by this exactly? You mean there should be a clear note about the Feature Blog opt-in reminder to take place right after enhancement freeze, so something around line#133?
Co-authored-by: Agustina Barbetta <[email protected]>
New changes are detected. LGTM label has been removed. |
What type of PR is this:
/kind documentation
What this PR does / why we need it:
Update the Comms handbook with the most recent details, and correct any parts for easier review.
Which issue(s) this PR fixes:
Updates #2718