Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark large list requests #34216

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Benchmark large list requests #34216

merged 1 commit into from
Jan 28, 2025

Conversation

serathius
Copy link
Contributor

@serathius serathius commented Jan 27, 2025 •
edited
Loading

Matching CI setup for kubernetes/perf-tests#3141

/cc @mborsz @tosi3k

@k8s-ci-robot k8s-ci-robot requested review from mborsz and tosi3k January 27, 2025 15:14
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 27, 2025
@tosi3k
Copy link
Member

tosi3k commented Jan 27, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2025
@serathius serathius force-pushed the benchmark-list branch 3 times, most recently from a06e039 to 81ebd41 Compare January 28, 2025 09:09
@mborsz
Copy link
Member

mborsz commented Jan 28, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz, serathius, tosi3k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2025
@mborsz
Copy link
Member

mborsz commented Jan 28, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6ac60e2 into kubernetes:master Jan 28, 2025
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@serathius: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-scalability-periodic-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-periodic-jobs.yaml

In response to this:

Matching CI setup for kubernetes/perf-tests#3141

/cc @mborsz @tosi3k

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@serathius serathius mentioned this pull request Jan 28, 2025
Open
@BenTheElder BenTheElder mentioned this pull request Feb 10, 2025
Closed
BenTheElder
BenTheElder reviewed Feb 10, 2025
View reviewed changes
config/jobs/kubernetes/sig-scalability/sig-scalability-periodic-jobs.yaml
- --gcp-node-size=e2-standard-32
- --gcp-node-image=gci
- --gcp-nodes=1
- --gcp-project-type=scalability-scale-project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be careful approving jobs with --gcp-project-type=scalability-scale-project, this is the 5k node type which we only have one of.

This should be scalability-project, I think #34305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@mborsz mborsz Awaiting requested review from mborsz

@tosi3k tosi3k Awaiting requested review from tosi3k

Assignees

@mborsz mborsz

@tosi3k tosi3k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serathius @tosi3k @mborsz @k8s-ci-robot @BenTheElder