-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIG Node: add bart0sh as approver #34273
Conversation
+1 Ed is very active and did a lot of good contributions in this area |
Huge +1. |
a big +1 from me as well! |
/assign @mrunalp @SergeyKanzhelev @dchen1107 |
+1 from me!! |
I am supportive. Just from the logistical standpoint, I suggest we merge this first: #34280 |
We have a coverage gap for the European time zone, which makes it hard to get even small changes applied without waiting several days. Ed has been active as reviewer already and actively participates in the CI job maintenance.
5fe7510
to
cb0dece
Compare
Rebased and done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections expressed for 3 days.
/lgtm
/approve
/lgtm Well deserved recognition |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, pohly, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We have a coverage gap for the European time zone, which makes it hard to get even small changes applied without waiting several days. Ed has been active as reviewer already and actively participates in the CI job maintenance.