Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIG Node: add bart0sh as approver #34273

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Feb 5, 2025

We have a coverage gap for the European time zone, which makes it hard to get even small changes applied without waiting several days. Ed has been active as reviewer already and actively participates in the CI job maintenance.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 5, 2025
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 5, 2025
@ffromani
Copy link
Contributor

ffromani commented Feb 5, 2025

Ed has been active as reviewer already and actively participates in the CI job maintenance.

+1 Ed is very active and did a lot of good contributions in this area

@kannon92
Copy link
Contributor

kannon92 commented Feb 5, 2025

Huge +1.
/assign @kubernetes/sig-node-leads

@haircommander
Copy link
Contributor

a big +1 from me as well!

@kannon92
Copy link
Contributor

kannon92 commented Feb 5, 2025

/assign @mrunalp @SergeyKanzhelev @dchen1107

@swatisehgal
Copy link
Contributor

+1 from me!!

@SergeyKanzhelev
Copy link
Member

I am supportive.

Just from the logistical standpoint, I suggest we merge this first: #34280

@SergeyKanzhelev
Copy link
Member

@pohly or @bart0sh can you change this PR to add @bart0sh to sig-node-test-approvers?

sig-node-test-approvers:

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2025
We have a coverage gap for the European time zone, which makes it hard to get
even small changes applied without waiting several days. Ed has been active as
reviewer already and actively participates in the CI job maintenance.
@pohly pohly force-pushed the sig-node-ed-approver branch from 5fe7510 to cb0dece Compare February 7, 2025 19:40
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2025
@pohly
Copy link
Contributor Author

pohly commented Feb 7, 2025

can you change this PR to add @bart0sh to sig-node-test-approvers?

Rebased and done.

Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections expressed for 3 days.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2025
@aojea
Copy link
Member

aojea commented Feb 9, 2025

/lgtm
/approve

Well deserved recognition

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, pohly, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit 07e4ac6 into kubernetes:master Feb 9, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

10 participants