Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move compat versions feature gate tests to kubekins image for jq and yq deps #34284

Merged
merged 1 commit into from
Feb 6, 2025
Merged

test: move compat versions feature gate tests to kubekins image for jq and yq deps #34284

merged 1 commit into from
Feb 6, 2025

Conversation

aaron-prindle
Copy link
Contributor

@aaron-prindle aaron-prindle commented Feb 6, 2025 •
edited
Loading

Fixes issue with current compatibility-versions-feature-gate-test where yq and jq deps the test depends are are not installed in the original container image. Moves the test to use kubekins-e2e which has these tools:

https://testgrid.k8s.io/sig-testing-kind#compatibility-versions-feature-gate-test

Validating features for 1.32...
/home/prow/go/src/k8s.io/kubernetes/../test-infra/experiment/compatibility-versions/validate-compatibility-versions-feature-gates.sh: line 69: yq: command not found
/home/prow/go/src/k8s.io/kubernetes/../test-infra/experiment/compatibility-versions/validate-compatibility-versions-feature-gates.sh: line 69: jq: command not found

/sig api-machinery
/assign @BenTheElder

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 6, 2025
BenTheElder
BenTheElder reviewed Feb 6, 2025
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaron-prindle, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit c42359d into kubernetes:master Feb 6, 2025
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@aaron-prindle: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key compatibility-versions-e2e.yaml using file config/jobs/kubernetes/sig-testing/compatibility-versions-e2e.yaml

In response to this:

Fixes issue with current compatibility-versions-feature-gate-test where yq and jq deps the test depends are are not installed in the original container image. Moves the test to use kubekins-e2e which has these tools:

https://testgrid.k8s.io/sig-testing-kind#compatibility-versions-feature-gate-test

Validating features for 1.32...
/home/prow/go/src/k8s.io/kubernetes/../test-infra/experiment/compatibility-versions/validate-compatibility-versions-feature-gates.sh: line 69: yq: command not found
/home/prow/go/src/k8s.io/kubernetes/../test-infra/experiment/compatibility-versions/validate-compatibility-versions-feature-gates.sh: line 69: jq: command not found

/sig api-machinery
/assign @BenTheElder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

BenTheElder
BenTheElder reviewed Feb 6, 2025
View reviewed changes
config/jobs/kubernetes/sig-testing/compatibility-versions-e2e.yaml
@@ -144,7 +144,7 @@ periodics:
path_alias: k8s.io/test-infra
spec:
containers:
- image: gcr.io/k8s-staging-test-infra/krte:v20241230-3006692a6f-master
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20250205-f1f3519e6b-master
imagePullPolicy: Always # pull latest image for canary testing
command:
- wrapper.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, wait, this has to use runner.sh (kubekins-e2e has some subtle differences ...)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's it, though we can also drop the imagePullPolicy: Always line, this job isn't using a "canary" image and always pulling is just slowing down startup (We don't mutate these date-sha tags)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made these changes in: #34285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@chases2 chases2 Awaiting requested review from chases2

@Priyankasaggu11929 Priyankasaggu11929 Awaiting requested review from Priyankasaggu11929

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaron-prindle @k8s-ci-robot @BenTheElder