fix: resolve incorrect kubelet version on e2e compat versions test using 2 step upgrade process #34304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aaron-prindle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
sig/testing
k8s-ci-robot
added
approved
|
/sig api-machinery /assign @BenTheElder |
k8s-ci-robot
added
the
sig/api-machinery
aaron-prindle
force-pushed
the
kubelet-issue-fix
branch
from
abc639c to
92364f7
Compare
…ing 2 step upgrade process
aaron-prindle
force-pushed
the
kubelet-issue-fix
branch
from
92364f7 to
00dbf13
Compare
aojea
reviewed
Feb 9, 2025
aaron-prindle
force-pushed
the
kubelet-issue-fix
branch
2 times, most recently
from
50f5786 to
18d36a9
Compare
aaron-prindle
force-pushed
the
kubelet-issue-fix
branch
from
18d36a9 to
636c64d
Compare
|
/cc @Jefftree |
BenTheElder
reviewed
Feb 10, 2025
Jefftree
reviewed
Feb 11, 2025
aaron-prindle
force-pushed
the
kubelet-issue-fix
branch
from
2b7631f to
6e04fc0
Compare
BenTheElder
reviewed
Feb 12, 2025
experiment/compatibility-versions/e2e-k8s-compatibility-versions.sh
Outdated
Show resolved
Hide resolved
BenTheElder
reviewed
Feb 12, 2025
BenTheElder
reviewed
Feb 12, 2025
experiment/compatibility-versions/e2e-k8s-compatibility-versions.sh
Outdated
Show resolved
Hide resolved
aaron-prindle
force-pushed
the
kubelet-issue-fix
branch
from
6e04fc0 to
e3f7425
Compare
BenTheElder
reviewed
Feb 13, 2025
| update_kubelet() { | ||
| for n in $NODES; do | ||
| # Backup previous kubelet | ||
| docker exec $n cp /usr/bin/kubelet /usr/bin/kubelet.bak |
There was a problem hiding this comment.
Todo: use something like which kubelet to avoid depending on the exact path.
BenTheElder
reviewed
Feb 13, 2025
| for n in $CONTROL_PLANE_NODES; do | ||
| for i in $CONTROL_PLANE_COMPONENTS; do | ||
| kind load image-archive ${IMAGES_PATH}/${i}.tar --name ${CLUSTER_NAME} --nodes $n | ||
| docker exec $n sed -i.bak -r "s|^(.*image\:.*)\:.*$|\1-amd64\:${DOCKER_TAG}|" /etc/kubernetes/manifests/$i.yaml |
There was a problem hiding this comment.
This path is at least a kubeadm default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #33849