Skip to content

Conversation

@justinsb
Copy link
Member

We want to build from the root, but cloudbuild.yaml is in a subdir.

We want to build from the root, but cloudbuild.yaml is in a subdir.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 17, 2025
Copy link

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@jakobmoellerdev: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2025
@a-hilaly
Copy link
Member

/lgtm

@a-hilaly
Copy link
Member

/cc @hakman @ameukam

@hakman
Copy link
Member

hakman commented Oct 20, 2025

/approve

@a-hilaly
Copy link
Member

/cc @BenTheElder

@a-hilaly
Copy link
Member

/cc @dims

@dims
Copy link
Member

dims commented Oct 20, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, dims, hakman, jakobmoellerdev, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit e1ecea8 into kubernetes:master Oct 20, 2025
6 checks passed
@k8s-ci-robot
Copy link
Contributor

@justinsb: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key k8s-staging-kro.yaml using file config/jobs/image-pushing/k8s-staging-kro.yaml

In response to this:

We want to build from the root, but cloudbuild.yaml is in a subdir.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants