Remove Required from nodePortAddresses in kube-proxy-config.v1alpha1 #51605
Conversation
…y-config.v1alpha1 since documentation state the default value for `--nodeport-addresses` is an empty list. For reference: https://kubernetes.io/docs/concepts/services-networking/service/#service-nodeport-custom-listen-address Code also throws a warning not an error when no value is set for `-nodeport-addresses`: https://github.com/kubernetes/kubernetes/blob/master/cmd/kube-proxy/app/server.go#L300C1-L310C1
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XS
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @tarikly , this is an auto-generated file. You shall edit the upstream file in https://github.com/kubernetes/kubernetes /retitle Remove Required from nodePortAddresses in kube-proxy-config.v1alpha1 |
k8s-ci-robot
changed the title
nodePortAddresses kube-proxy-config.v1alpha1 since documentation state the default value for --nodeport-addresses is an empty list.
Update docs - remove Required info from
nodePortAddressesRemove Required info from
nodePortAddresseskube-proxy-config.v1alpha1 since documentation state the default value for--nodeport-addressesis an empty list.For reference:
https://kubernetes.io/docs/concepts/services-networking/service/#service-nodeport-custom-listen-address
Code also throws a warning not an error when no value is set for
-nodeport-addresses: https://github.com/kubernetes/kubernetes/blob/master/cmd/kube-proxy/app/server.go#L300C1-L310C1