Skip to content

Fix broken example volume links #51608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix broken example volume links #51608

wants to merge 2 commits into from

Conversation

intojhanurag
Copy link
Contributor

Fixes #51495
This PR updates broken volume example links for:

  • Fibre Channel
  • ISCSI
  • NFS
  • Portworx

These folders were removed from the upstream kubernetes/examples repo. I’ve updated the links accordingly.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 15, 2025
@k8s-ci-robot k8s-ci-robot requested a review from saad-ali July 15, 2025 03:22
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 15, 2025
@k8s-ci-robot k8s-ci-robot requested a review from thockin July 15, 2025 03:22
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 15, 2025
@intojhanurag
Copy link
Contributor Author

Hi @divya-mohan0209, kindly requesting a review and approval when you get a chance. Thanks in advance!

@netlify Netlify
Copy link

netlify bot commented Jul 15, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9fbaa42
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6878731d0e95c70008fec919
😎 Deploy Preview https://deploy-preview-51608--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@reylejano
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2025
lmktfy
lmktfy reviewed Jul 15, 2025
View reviewed changes
Copy link
Contributor

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we remove mention of these links?

content/en/docs/concepts/storage/volumes.md Outdated
@@ -317,7 +317,7 @@ You must configure FC SAN Zoning to allocate and mask those LUNs (volumes) to th
beforehand so that Kubernetes hosts can access them.
{{< /note >}}

See the [fibre channel example](https://github.com/kubernetes/examples/tree/master/staging/volumes/fibre_channel)
See the [fibre channel example](https://github.com/kubernetes/examples/tree/master/_archived/volumes/fibre_channel)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better: remove the paragraph.

content/en/docs/concepts/storage/volumes.md Outdated
@@ -663,7 +663,7 @@ and then serve it in parallel from as many Pods as you need. Unfortunately,
iSCSI volumes can only be mounted by a single consumer in read-write mode.
Simultaneous writers are not allowed.

See the [iSCSI example](https://github.com/kubernetes/examples/tree/master/volumes/iscsi) for more details.
See the [iSCSI example](https://github.com/kubernetes/examples/tree/master/_archived/volumes/iscsi) for more details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better: remove the paragraph.

content/en/docs/concepts/storage/volumes.md Outdated
@@ -774,7 +774,7 @@ use [/etc/nfsmount.conf](https://man7.org/linux/man-pages/man5/nfsmount.conf.5.h
You can also mount NFS volumes via PersistentVolumes which do allow you to set mount options.
{{< /note >}}

See the [NFS example](https://github.com/kubernetes/examples/tree/master/staging/volumes/nfs)
See the [NFS example](https://github.com/kubernetes/examples/tree/master/_archived/volumes/nfs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better: remove the paragraph.

content/en/docs/concepts/storage/volumes.md Outdated
@@ -826,7 +826,7 @@ before using it in the Pod.
{{< /note >}}

For more details, see the
[Portworx volume](https://github.com/kubernetes/examples/tree/master/staging/volumes/portworx/README.md) examples.
[Portworx volume](https://github.com/kubernetes/examples/blob/master/_archived/volumes/portworx/README.md) examples.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better: remove the paragraph.

Arhell
Arhell reviewed Jul 16, 2025
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@intojhanurag
Copy link
Contributor Author

intojhanurag commented Jul 16, 2025 •
edited
Loading

Hi @Arhell @lmktfy , thanks for the previous feedback! When you get a chance, could you please take another look at this PR? Should I remove the paragraph or it is good to go

@reylejano
Copy link
Member

I overlooked the Portworx volume example which should be removed according to KEP 1326 Removing third-party content in docs
Removing approve label until at minimum the portworx link is removed
/remove-approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 16, 2025
@intojhanurag intojhanurag force-pushed the fix-broken-nfs-links branch from aa946f0 to 9fbaa42 Compare July 17, 2025 03:50
@intojhanurag
Copy link
Contributor Author

Thanks for pointing that out! I've now removed the Portworx example paragraph in accordance with KEP-1326.
Also removed other outdated volume example paragraphs as suggested by previous reviewers.

Please let me know if anything else needs to be addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

@lmktfy lmktfy lmktfy left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

@thockin thockin Awaiting requested review from thockin

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NFS example link leads to a github 404 page
5 participants
@intojhanurag @reylejano @k8s-ci-robot @Arhell @lmktfy