Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove metrics logger #31

Merged
merged 9 commits into from
Dec 13, 2024
Merged

chore: remove metrics logger #31

merged 9 commits into from
Dec 13, 2024

Conversation

dongjiang1989
Copy link
Member

What type of PR is this?

/kind feature

  • Unittest
  • Coverage 80%+
  • Build Success

What this PR does / why we need it:

  1. remove metrics logger
  2. update package version

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: dongjiang <[email protected]>
@pull-request-size pull-request-size bot added the size/L size/L label Dec 13, 2024
Copy link

the-label-bot bot commented Dec 13, 2024

The Label Bot has predicted the following:

Category Value Confidence Applied Label

Copy link

codacy-production bot commented Dec 13, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (770af3d) 6971 6198 88.91%
Head commit (32e6064) 6969 (-2) 6196 (-2) 88.91% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#31) 13 13 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@github-actions github-actions bot requested a review from imlense December 13, 2024 03:57
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Signed-off-by: dongjiang <[email protected]>
Signed-off-by: dongjiang <[email protected]>
Signed-off-by: dongjiang <[email protected]>
update
Signed-off-by: dongjiang <[email protected]>
fix bug
Signed-off-by: dongjiang <[email protected]>
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.68%. Comparing base (3b913a3) to head (9951071).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   86.32%   85.68%   -0.64%     
==========================================
  Files          97       99       +2     
  Lines        6360     6474     +114     
==========================================
+ Hits         5490     5547      +57     
- Misses        697      752      +55     
- Partials      173      175       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: dongjiang <[email protected]>
Signed-off-by: dongjiang <[email protected]>
Signed-off-by: dongjiang <[email protected]>
@dongjiang1989 dongjiang1989 merged commit ed01077 into main Dec 13, 2024
12 checks passed
@dongjiang1989 dongjiang1989 deleted the fix-metrics-logger branch February 14, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant