Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed linting #60

Merged
merged 8 commits into from
Jan 30, 2025
Merged

fixed linting #60

merged 8 commits into from
Jan 30, 2025

Conversation

philprime
Copy link
Collaborator

  • style: applied formatting and linting
  • style: add more linting rules and SwiftLint plugin setup

@philprime philprime self-assigned this Jan 30, 2025
@philprime philprime enabled auto-merge (rebase) January 30, 2025 22:14
Copy link

github-actions bot commented Jan 30, 2025

Warnings
⚠️ Pull Request size seems relatively large. If this Pull Request contains multiple changes, please split each into separate PR will helps faster, easier review.

SwiftLint found issues

Severity File Reason
Warning Package.swift:8 Prefer at least one space after slashes for comments. (comment_spacing)
Warning Package.swift:25 Prefer at least one space after slashes for comments. (comment_spacing)
Warning Package.swift:26 Prefer at least one space after slashes for comments. (comment_spacing)
Warning Package.swift:27 Prefer at least one space after slashes for comments. (comment_spacing)
Warning Package.swift:28 Prefer at least one space after slashes for comments. (comment_spacing)
Warning Package.swift:35 Prefer at least one space after slashes for comments. (comment_spacing)
Warning HTTPAPIClient.swift:1 SwiftLint rule 'line_length' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)
Warning HTTPAPIClient.swift:6 Type body should span 200 lines or less excluding comments and whitespace: currently spans 201 lines (type_body_length)
Warning ResponseCookiesCodingTests.swift:15 Line should be 150 characters or less: currently 163 characters (line_length)
Warning ResponseCookiesCodingTests.swift:14 SwiftLint rule 'line_length' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)
Warning ResponseCookiesCodingTests.swift:11 Arguments should be either on the same line, or one per line. (multiline_arguments)
Warning ResponseCookiesCodingTests.swift:11 Arguments should be either on the same line, or one per line. (multiline_arguments)
Warning HTTPAPIClientE2ECombineTests.swift:11 Method 'setUp()' should call to super function (overridden_super_call)
Warning HTTPStatusCodeTests.swift:1 SwiftLint rule 'type_body_length' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)
Warning RequestPathParameterCodingTests.swift:62 SwiftLint rule 'xct_specific_matcher' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)
Warning ResponseHeaderCodingTests.swift:24 Arguments should be either on the same line, or one per line. (multiline_arguments)
Warning ResponseHeaderCodingTests.swift:24 Arguments should be either on the same line, or one per line. (multiline_arguments)
Warning ResponseHeaderCodingTests.swift:67 Arguments should be either on the same line, or one per line. (multiline_arguments)
Warning ResponseHeaderCodingTests.swift:67 Arguments should be either on the same line, or one per line. (multiline_arguments)
Warning ResponseHeaderCodingTests.swift:84 Arguments should be either on the same line, or one per line. (multiline_arguments)
Warning ResponseHeaderCodingTests.swift:84 Arguments should be either on the same line, or one per line. (multiline_arguments)

Generated by 🚫 Danger Swift against 524e5ae

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 47.72727% with 69 lines in your changes missing coverage. Please review.

Project coverage is 59.23%. Comparing base (4132309) to head (524e5ae).

Files with missing lines Patch % Lines
...s/URLEncodedFormCoding/URLEncodedFormDecoder.swift 16.00% 21 Missing ⚠️
Sources/Postie/HTTPAPIClient.swift 60.00% 10 Missing ⚠️
...tie/Strategies/Headers/DefaultHeaderStrategy.swift 0.00% 7 Missing ⚠️
Sources/Postie/Query/QueryItem.swift 25.00% 6 Missing ⚠️
Sources/Postie/Decoder/ResponseDecoding.swift 37.50% 5 Missing ⚠️
Sources/Postie/Query/QueryItemValue.swift 0.00% 5 Missing ⚠️
...codedFormCoding/URLEncodedElementConvertible.swift 33.33% 4 Missing ⚠️
...s/URLEncodedFormCoding/URLEncodedFormEncoder.swift 40.00% 3 Missing ⚠️
.../Encoder/RequestSingleValueEncodingContainer.swift 0.00% 2 Missing ⚠️
...es/PostieUtils/String+CamelCaseFromSnakeCase.swift 33.33% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   59.04%   59.23%   +0.19%     
==========================================
  Files          66       66              
  Lines        1631     1656      +25     
==========================================
+ Hits          963      981      +18     
- Misses        668      675       +7     
Flag Coverage Δ
unittests 59.23% <47.72%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philprime philprime merged commit 91803e1 into main Jan 30, 2025
6 checks passed
@philprime philprime deleted the fixed-linting branch January 30, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants