chore(check): verify that UPGRADE.md has changed after Role change #13396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to avoid frequent changes to RBAC and ensure that users who upgrade and have RBAC creation disabled will see a note about it in the UPGRADE.md.
Implementation information
I've added a
check/rbac
command to check for changed files, specifically looking forRole
,RoleBinding
,ClusterRole
, orClusterRoleBinding
. It also verifies thatUPGRADE.md
has been updated. If any RBAC-related changes are detected, the command will fail with a message.Supporting documentation
Fix: #13386