create and implement trait Resolve#5
Open
coriolinus wants to merge 2 commits intokurtbuilds:masterfrom
Open
Conversation
This makes it easier to use the various `ReferenceOr::<T>::resolve` methods in downstream functions which want to operate over any resolvable `T`. Also includes a few tiny implementation fixes where improvements could be made.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier to use the various
ReferenceOr::<T>::resolvemethods in downstream functions which want to operate over any resolvableT.Also includes a few tiny implementation fixes where improvements could be made. In particular, this swaps out panics for runtime error handling in several places.
There are also several instances where
rustfmtmade changes without any changes in the semantics of the code.trait Resolve#4