GDS refactor #5033
GDS refactor #5033
Conversation
| void setCoreValue(offset_t offset, degree_t value) { | ||
| coreValues[offset].store(value, std::memory_order_relaxed); | ||
| } | ||
| struct KcoreComputationState { |
There was a problem hiding this comment.
Revert the naming to CoreValues. Otherwise I find KcoreComputationState.isValid to be very confusing.
| class PValues { | ||
| public: | ||
| PValues(table_id_map_t<offset_t> maxOffsetMap, storage::MemoryManager* mm, double val) { | ||
| struct PrComputationState { |
There was a problem hiding this comment.
Ditto revert renaming.
| @@ -7,31 +7,31 @@ namespace kuzu { | |||
| namespace function { | |||
|
|
|||
| struct WeaklyConnectedComponentsFunction { | |||
| static constexpr const char* name = "WEAKLY_CONNECTED_COMPONENT"; | |||
| static constexpr const char* name = "GDS_WCC"; | |||
There was a problem hiding this comment.
revert all naming changes in this PR. We should add alias naming instead of renaming.
| @@ -87,6 +90,15 @@ class AtomicObjectArray { | |||
| } | |||
| return false; | |||
| } | |||
|
|
|||
| void compare_and_swap(const common::offset_t pos, double valToAdd) { | |||
There was a problem hiding this comment.
This is not what the function is doing. It's an addition using CAS, so call it addCAS.
Also for compare_exchange_strong_max do a similar naming with camel case.
| SCCState(const offset_t tableID, const offset_t numNodes, MemoryManager* mm) { | ||
| componentIDsMap.allocate(tableID, numNodes, mm); | ||
| componentIDs = componentIDsMap.getData(tableID); | ||
| struct SccComputationState { |
There was a problem hiding this comment.
I would also call this SCCIDs
| class ComponentIDs { | ||
| public: | ||
| ComponentIDs(const table_id_map_t<offset_t>& maxOffsetMap, MemoryManager* mm) { | ||
| struct WccComputationState { |
There was a problem hiding this comment.
Ditto revert renaming and I would merge this with SCCIDs. Also why we have Wcc, WCC, Scc, SCC at this same time? Let's use one convention and if we decide to change we change in one PR all together.
Contributor agreement