[TransferEngine] Fix QP leak in EndPointStore #1132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmatengss
reviewed
Dec 4, 2025
mooncake-transfer-engine/src/transport/rdma_transport/worker_pool.cpp
Outdated
Show resolved
Hide resolved
stmatengss
reviewed
Dec 4, 2025
Comment on lines
232
to
239
| // if (!endpoint->active()) { | ||
| // if (endpoint->inactiveTime() > 1.0) | ||
| // context_.deleteEndpoint( | ||
| // entry.first); // enable for re-establishation | ||
| // for (auto &slice : entry.second) | ||
| // failed_slice_list.push_back(slice); entry.second.clear(); | ||
| // continue; | ||
| // } |
Collaborator
|
Does this PR resolve the limited QP number issue? |
Collaborator
Author
This patch will eagerly destroy QPs if it is possible. So I think it's helpful to mitigate this issue. However Endpoint capacity is remained. |
Collaborator
|
Full review is required before merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
How Has This Been Tested?
This patch tries to mitigate problems from EndPoint Store management, including:
Simple test in local testbed.
Checklist