Skip to content

Add Quotes around paths. Resolves issues when a space is in user path name #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adamcoulombe wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add Quotes around paths. Resolves issues when a space is in user path name #1

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9ff6efe
add quotes around default key path
adamcoulombe Feb 4, 2021
a81a7ba
add quotes to key paths
adamcoulombe Feb 4, 2021
ad423fb
add quote around path
adamcoulombe Feb 4, 2021
07ccc38
add quote around path
adamcoulombe Feb 4, 2021
1a56808
add quotes around path
adamcoulombe Feb 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions bin/http-server
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,15 +115,15 @@ function listen(port) {

if (!fs.existsSync(defaultCertPath)) {
log('Generating and using default cert and key files in: '.yellow + __dirname.cyan);
exec('openssl genrsa -out ' + defaultKeyPath + ' 4096', function(err) {
exec('openssl genrsa -out "' + defaultKeyPath + '" 4096', function(err) {
handleCreatingCertError(err);
err || exec('openssl req -new -key ' + defaultKeyPath + ' -out ' + defaultCSRPath +
' -subj "/C=US/ST=California/L=San Francisco/O=Local-Company' +
err || exec('openssl req -new -key "' + defaultKeyPath + '" -out "' + defaultCSRPath +
'" -subj "/C=US/ST=California/L=San Francisco/O=Local-Company' +
'/OU=dev/CN=localhost/[email protected]"', function(err) {

handleCreatingCertError(err);
err || exec('openssl x509 -req -days 1000 -in ' + defaultCSRPath + ' -signkey ' +
defaultKeyPath + ' -out ' + defaultCertPath, function(err) {
err || exec('openssl x509 -req -days 1000 -in "' + defaultCSRPath + '" -signkey "' +
defaultKeyPath + '" -out "' + defaultCertPath + '"', function(err) {

handleCreatingCertError(err);
err || createServer();
Expand Down