Open
Conversation
622c0e4 to
a8445b6
Compare
Contributor
Author
|
fixupまちがえました 🙇 |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## stable #296 +/- ##
==========================================
- Coverage 90.31% 90.25% -0.07%
==========================================
Files 64 64
Lines 2788 2781 -7
==========================================
- Hits 2518 2510 -8
- Misses 270 271 +1 ☔ View full report in Codecov by Sentry. |
Owner
|
ありがとうございます! コード見る限りよさそうです!もともとのretryはコンテスト開始前にツールを起動した場合の失敗を主に想定していたんですが、ユースケースの区別なくネットワーク通信の深いところで統一的にretryを行うというのには同意です。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change needed?
問題の取得に失敗し、
SampleDetectionErrorが発生することがある。(以前より失敗することが増えた気がする)What did you implement?
Retryにより3回リトライするようにした。初回は0.5秒。(リトライに失敗した場合はRetryErrorが発生する)prepare_contestのほうのリトライは不要になったので削除した。What behavior do you expect?
atcodertools.tools.envgen.EnvironmentInitializationErrorが発生すること。