Open
Conversation
fdb7ae4 to
86f4af9
Compare
Owner
|
私生活が忙しく余裕がないという都合で長らく放置しており申し訳ないです。 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change needed?
NixOSから使いたいのでNixpkgsにatcoder-toolsを登録したい。
しかし、Nixpkgsには既にJinja2 3.0.0以降のバージョンしか存在しないため、post-checkでエラーになる。
そのため、atcoder-toolsのjinja2を
^3.0.0に移行したい。What did you implement?
autoescapeを明示的にFalseにautoescapeに関してはLLMに質問したところ、Jinja2 3.0.0からautoescape=Trueがデフォルトになるとのことで明示的に変更したのですが、Jinja2のchangelogを読んでも該当箇所を見つけられず。もし、
autoescape=Falseで試して問題なければ冗長なのでこの変更は取り消します。→
autoescape=Falseで試しても<,>の部分はエスケープされませんでした。よって明示的に
autoescape=Falseを指定する必要はないため削除しました。What behavior do you expect?
手元では
して
<,>がエスケープされていないことを確認しました。