Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/custom fields map panic #570

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Fix/custom fields map panic #570

merged 2 commits into from
Feb 28, 2025

Conversation

demeyerthom
Copy link
Member

Fix concurrent map write. With thanks to @Multiply

Fixes #563

NEW FEATURES | UPGRADE NOTES | ENHANCEMENTS | BUG FIXES | EXPERIMENTS

  • Add concurrency lock when fetching types
  • Add test to check if it works

@demeyerthom demeyerthom requested a review from a team as a code owner February 21, 2025 14:03
@demeyerthom demeyerthom mentioned this pull request Feb 21, 2025
Closed
@demeyerthom demeyerthom merged commit c577c08 into main Feb 28, 2025
3 checks passed
@demeyerthom demeyerthom deleted the fix/custom-fields-map-panic branch February 28, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichielBijland MichielBijland Awaiting requested review from MichielBijland MichielBijland is a code owner automatically assigned from labd/go

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fatal error: concurrent map writes
2 participants
@demeyerthom @Multiply