#145 ignore empty questions inserting editing intents#161
Open
Miguel-Alves wants to merge 4 commits intomasterfrom
Open
#145 ignore empty questions inserting editing intents#161Miguel-Alves wants to merge 4 commits intomasterfrom
Miguel-Alves wants to merge 4 commits intomasterfrom
Conversation
This was referenced Mar 2, 2021
gabibguedes
requested changes
Apr 20, 2021
Collaborator
gabibguedes
left a comment
gabibguedes
left a comment
There was a problem hiding this comment.
I couldn't get it to work properly, it still doesn't let me save intents with empty baloons.
| @@ -1,4 +1,4 @@ | |||
| export const BASE = process.env.REACT_APP_URL_API + 'api/v1/'; | |||
| export const BASE = 'http://localhost:8000/api/v1/'; | |||
Collaborator
There was a problem hiding this comment.
Change it back to the env variable, with it we can set the API endpoint on production environments
Collaborator
Author
There was a problem hiding this comment.
@gabibguedes are you using the dev environment or the docker?
Until the docker problem is solved, using the docker is not possible cause it doesnt reflect changes we made to the code.
Also, as the docker doesnt work properly, we need this variable set this way as described on #157
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the needs of #145, this PR is solving the problems described.
This Pull Request resolves #145