Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use XDG standard icon names #113

Merged
merged 2 commits into from
Jul 27, 2024
Merged

Use XDG standard icon names #113

merged 2 commits into from
Jul 27, 2024

Conversation

rocka
Copy link
Contributor

@rocka rocka commented Jul 27, 2024

Use XDG strandard icon names1 instead of non-standard gtk- ones, for better theming support. Examples with breeze-gtk and breeze-icons:

Before After
image image
image image
image image

Footnotes

  1. https://specifications.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html ↩

@lah7 lah7 added the patch improvement Improves an existing patch label Jul 27, 2024
lah7
lah7 approved these changes Jul 27, 2024
View reviewed changes
Copy link
Owner

@lah7 lah7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! That looks a lot better! 👍🏼

I guess it's time to uninstall gnome-icon-theme and gnome-icon-theme-symbolic packages, which were mostly filling in where 🚫 's were seen up to now.

@lah7 lah7 changed the title Use XDG stardard icon names Use XDG standard icon names Jul 27, 2024
@lah7 lah7 merged commit a42ef19 into lah7:master Jul 27, 2024
2 checks passed
@rocka rocka deleted the xdg-icon-name branch July 28, 2024 05:43
lah7 added a commit that referenced this pull request Jan 26, 2025
@lah7
Fix XDG icons in message dialogs again
5edc145 
My bad, I overlooked the icon change when reviewing the changes in #114
(9129a63)

Originally patched in #113 (a42ef19)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lah7 lah7 lah7 approved these changes

Assignees
No one assigned
Labels
patch improvement Improves an existing patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rocka @lah7