Update appearance__message-dialogs.patch #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lah7
added
the
waiting for upstream
lah7
added
patch improvement
lah7
approved these changes
Jan 25, 2025
There was a problem hiding this comment.
Thank you very much! Much appreciated!
Must be a Gentoo user rolling with upstream's mastergtk-3-24! 😄
Apologies for the silence - I was waiting for upstream to make a new release, just for the sake of simplicity of keeping our master branch linear with the latest GTK release (mainly, so our CI passes)
lah7
added a commit
that referenced
this pull request
Jan 26, 2025
lah7
added a commit
that referenced
this pull request
Jan 26, 2025
Upstream caused a patch conflict: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/7587 The changes in #114 (9129a63) to fix the patch were not 100% complete. The icon variable was set outside [update_accessible_name] of the function [setup_type] that actually sets this icon. Even though repeating the case select is a bit like code duplication, it works and fixes the regression.
lah7
added a commit
that referenced
this pull request
Jan 26, 2025
Upstream caused a patch conflict: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/7587 The changes in #114 (9129a63) to fix the patch were not 100% complete. The icon variable was set outside [update_accessible_name] of the function [setup_type] that actually sets this icon. Even though repeating the case select is a bit like code duplication, it works and fixes the regression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gitlab.gnome.org/GNOME/gtk/-/commit/82213003aa2c45caef890c3eb585e4a37d54013b broke the appearance__message-dialogs.patch. This PR fixes that.
HTH