Open
Conversation
mmsc2
changed the title
Oppen
reviewed
Nov 10, 2022
Contributor
Oppen
left a comment
Oppen
left a comment
There was a problem hiding this comment.
LGTM except from the questions below.
On another note, we should start thinking about adding a proper test framework for Python I believe. Probably PyTest.
| maturin develop && \ | ||
| python3 hints_tests.py && \ | ||
| python3 get_builtins_initial_stack.py && \ | ||
| ./run_python_tests.sh && \ |
Contributor
There was a problem hiding this comment.
Is the PYENV_VERSION still the same here? I'm not entirely sure if the venv takes care of that.
Contributor
Author
There was a problem hiding this comment.
As far as i know yes, venv takes care about the python version with which the tests are ran.
Comment on lines
+2
to
+7
| echo "Running hint tests" | ||
| python3 tests/hints_tests.py | ||
| python3 tests/get_builtins_initial_stack.py | ||
|
|
||
| echo "Running prepare_os_context integration tests" | ||
| python3 tests/prepare_os_context.py |
Juan-M-V
approved these changes
Nov 16, 2022
Oppen
approved these changes
Jan 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.