Skip to content

Bump LLVM #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

Bump LLVM #1381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
4046a22
bump llvm-sys, mlir-sys, melior to llvm 20
FrancoGiachetta Sep 3, 2025
dd3180a
remove unwanted files
FrancoGiachetta Sep 3, 2025
5f8e31a
fix clippy
FrancoGiachetta Sep 4, 2025
ec10936
add llvm_call helper
FrancoGiachetta Sep 4, 2025
a1cc623
remove unwanted files
FrancoGiachetta Sep 4, 2025
ae497fe
update date some missing commands to llvm 20
FrancoGiachetta Sep 5, 2025
b157904
Merge branch 'main' into bump-llvm-20
FrancoGiachetta Sep 5, 2025
ea542dc
fix llvm.call attributes
FrancoGiachetta Sep 5, 2025
7ffa72d
fix llvm.call attributes
FrancoGiachetta Sep 5, 2025
95ef963
make llvm_call just an operation builder
FrancoGiachetta Sep 8, 2025
0e3a3f5
bump melior
FrancoGiachetta Sep 8, 2025
2352fd6
clippy
FrancoGiachetta Sep 8, 2025
f57e5d0
clippy
FrancoGiachetta Sep 8, 2025
e0e2700
move LLVMCalleType to operation_ext
FrancoGiachetta Sep 8, 2025
bda23ca
add some comments to mlirLLVMDISubprogramAttrGet call
FrancoGiachetta Sep 8, 2025
d032da2
remove pub(crate)
FrancoGiachetta Sep 8, 2025
ec97ae5
update replay and sequencer version in starknet-blocks.yml
FrancoGiachetta Sep 8, 2025
80e6b12
call llvm_call instead of building llvm.call by hand in runtime bindings
FrancoGiachetta Sep 8, 2025
a0730a8
use melior 0.23.0
FrancoGiachetta Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/install-linux-deps/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ runs:
- name: Add LLVM Debian repository
uses: myci-actions/add-deb-repo@11
with:
repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-19 main
repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-20 main
repo-name: llvm-repo
keys-asc: https://apt.llvm.org/llvm-snapshot.gpg.key
- name: Update and upgrade APT
shell: bash
run: sudo apt-get update && sudo apt-get upgrade -y
- name: Install LLVM
shell: bash
run: sudo apt-get install llvm-19 llvm-19-dev llvm-19-runtime clang-19 clang-tools-19 lld-19 libpolly-19-dev libmlir-19-dev mlir-19-tools
run: sudo apt-get install llvm-20 llvm-20-dev llvm-20-runtime clang-20 clang-tools-20 lld-20 libpolly-20-dev libmlir-20-dev mlir-20-tools
26 changes: 13 additions & 13 deletions .github/workflows/bench-hyperfine.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ jobs:
runs-on: ubuntu-24.04
env:
CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
MLIR_SYS_190_PREFIX: /usr/lib/llvm-19/
TABLEGEN_190_PREFIX: /usr/lib/llvm-19/
LLVM_SYS_191_PREFIX: /usr/lib/llvm-19/
MLIR_SYS_200_PREFIX: /usr/lib/llvm-20/
TABLEGEN_200_PREFIX: /usr/lib/llvm-20/
LLVM_SYS_201_PREFIX: /usr/lib/llvm-20/
steps:
- uses: actions/checkout@v4
- name: check and free hdd space left
Expand Down Expand Up @@ -50,11 +50,11 @@ jobs:
- name: add llvm deb repository
uses: myci-actions/add-deb-repo@11
with:
repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-19 main
repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-20 main
repo-name: llvm-repo
keys-asc: https://apt.llvm.org/llvm-snapshot.gpg.key
- name: Install LLVM
run: sudo apt-get install llvm-19 llvm-19-dev llvm-19-runtime clang-19 clang-tools-19 lld-19 libpolly-19-dev libmlir-19-dev mlir-19-tools
run: sudo apt-get install llvm-20 llvm-20-dev llvm-20-runtime clang-20 clang-tools-20 lld-20 libpolly-20-dev libmlir-20-dev mlir-20-tools
- name: Install hyperfine
uses: taiki-e/install-action@v2
with:
Expand Down Expand Up @@ -85,9 +85,9 @@ jobs:

build-binaries:
env:
MLIR_SYS_190_PREFIX: /usr/lib/llvm-19/
LLVM_SYS_191_PREFIX: /usr/lib/llvm-19/
TABLEGEN_190_PREFIX: /usr/lib/llvm-19/
MLIR_SYS_200_PREFIX: /usr/lib/llvm-20/
LLVM_SYS_201_PREFIX: /usr/lib/llvm-20/
TABLEGEN_200_PREFIX: /usr/lib/llvm-20/
RUST_LOG: cairo_native=debug,cairo_native_test=debug
strategy:
matrix:
Expand Down Expand Up @@ -129,12 +129,12 @@ jobs:
if: ${{ steps.cache-binary.outputs.cache-hit != 'true' || steps.cache-library.outputs.cache-hit != 'true' }}
uses: myci-actions/add-deb-repo@11
with:
repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-19 main
repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-20 main
repo-name: llvm-repo
keys-asc: https://apt.llvm.org/llvm-snapshot.gpg.key
- name: Install LLVM
if: ${{ steps.cache-binary.outputs.cache-hit != 'true' || steps.cache-library.outputs.cache-hit != 'true' }}
run: sudo apt-get update && sudo apt-get install llvm-19 llvm-19-dev llvm-19-runtime clang-19 clang-tools-19 lld-19 libpolly-19-dev libmlir-19-dev mlir-19-tools
run: sudo apt-get update && sudo apt-get install llvm-20 llvm-20-dev llvm-20-runtime clang-20 clang-tools-20 lld-20 libpolly-20-dev libmlir-20-dev mlir-20-tools

- name: Checkout base commit
if: ${{ steps.cache-binary.outputs.cache-hit != 'true' || steps.cache-library.outputs.cache-hit != 'true' }}
Expand All @@ -155,9 +155,9 @@ jobs:

run-bench:
env:
MLIR_SYS_190_PREFIX: /usr/lib/llvm-19/
LLVM_SYS_191_PREFIX: /usr/lib/llvm-19/
TABLEGEN_190_PREFIX: /usr/lib/llvm-19/
MLIR_SYS_200_PREFIX: /usr/lib/llvm-20/
LLVM_SYS_201_PREFIX: /usr/lib/llvm-20/
TABLEGEN_200_PREFIX: /usr/lib/llvm-20/
RUST_LOG: cairo_native=debug,cairo_native_test=debug
strategy:
matrix:
Expand Down
46 changes: 23 additions & 23 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ jobs:
name: clippy
runs-on: ubuntu-24.04
env:
MLIR_SYS_190_PREFIX: /usr/lib/llvm-19/
LLVM_SYS_191_PREFIX: /usr/lib/llvm-19/
TABLEGEN_190_PREFIX: /usr/lib/llvm-19/
MLIR_SYS_200_PREFIX: /usr/lib/llvm-20/
LLVM_SYS_201_PREFIX: /usr/lib/llvm-20/
TABLEGEN_200_PREFIX: /usr/lib/llvm-20/
steps:
- uses: actions/checkout@v4
- uses: dtolnay/[email protected]
Expand All @@ -28,11 +28,11 @@ jobs:
- name: add llvm deb repository
uses: myci-actions/add-deb-repo@11
with:
repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-19 main
repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-20 main
repo-name: llvm-repo
keys-asc: https://apt.llvm.org/llvm-snapshot.gpg.key
- name: Install LLVM
run: sudo apt-get install llvm-19 llvm-19-dev llvm-19-runtime clang-19 clang-tools-19 lld-19 libpolly-19-dev libmlir-19-dev mlir-19-tools
run: sudo apt-get install llvm-20 llvm-20-dev llvm-20-runtime clang-20 clang-tools-20 lld-20 libpolly-20-dev libmlir-20-dev mlir-20-tools
- name: Clippy
run: make check

Expand Down Expand Up @@ -83,9 +83,9 @@ jobs:
udeps:
runs-on: ubuntu-24.04
env:
MLIR_SYS_190_PREFIX: /usr/lib/llvm-19/
LLVM_SYS_191_PREFIX: /usr/lib/llvm-19/
TABLEGEN_190_PREFIX: /usr/lib/llvm-19/
MLIR_SYS_200_PREFIX: /usr/lib/llvm-20/
LLVM_SYS_201_PREFIX: /usr/lib/llvm-20/
TABLEGEN_200_PREFIX: /usr/lib/llvm-20/
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@master
Expand All @@ -96,21 +96,21 @@ jobs:
- name: add llvm deb repository
uses: myci-actions/add-deb-repo@11
with:
repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-19 main
repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-20 main
repo-name: llvm-repo
keys-asc: https://apt.llvm.org/llvm-snapshot.gpg.key
- name: Install LLVM
run: sudo apt-get install llvm-19 llvm-19-dev llvm-19-runtime clang-19 clang-tools-19 lld-19 libpolly-19-dev libmlir-19-dev mlir-19-tools
run: sudo apt-get install llvm-20 llvm-20-dev llvm-20-runtime clang-20 clang-tools-20 lld-20 libpolly-20-dev libmlir-20-dev mlir-20-tools
- name: Machete
uses: bnjbvr/cargo-machete@main

test:
name: test (linux, amd64)
runs-on: ubuntu-24.04
env:
MLIR_SYS_190_PREFIX: /usr/lib/llvm-19/
LLVM_SYS_191_PREFIX: /usr/lib/llvm-19/
TABLEGEN_190_PREFIX: /usr/lib/llvm-19/
MLIR_SYS_200_PREFIX: /usr/lib/llvm-20/
LLVM_SYS_201_PREFIX: /usr/lib/llvm-20/
TABLEGEN_200_PREFIX: /usr/lib/llvm-20/
RUST_LOG: cairo_native=debug,cairo_native_test=debug
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -140,12 +140,12 @@ jobs:
- name: add llvm deb repository
uses: myci-actions/add-deb-repo@11
with:
repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-19 main
repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-20 main
repo-name: llvm-repo
keys-asc: https://apt.llvm.org/llvm-snapshot.gpg.key
- run: sudo apt-get update && sudo apt-get upgrade -y
- name: Install LLVM
run: sudo apt-get install llvm-19 llvm-19-dev llvm-19-runtime clang-19 clang-tools-19 lld-19 libpolly-19-dev libmlir-19-dev mlir-19-tools
run: sudo apt-get install llvm-20 llvm-20-dev llvm-20-runtime clang-20 clang-tools-20 lld-20 libpolly-20-dev libmlir-20-dev mlir-20-tools
- name: Install deps
run: make deps
- name: test
Expand All @@ -159,9 +159,9 @@ jobs:
env:
CARGO_TERM_COLOR: always
LIBRARY_PATH: /opt/homebrew/lib
MLIR_SYS_190_PREFIX: /opt/homebrew/opt/llvm@19
LLVM_SYS_191_PREFIX: /opt/homebrew/opt/llvm@19
TABLEGEN_190_PREFIX: /opt/homebrew/opt/llvm@19
MLIR_SYS_200_PREFIX: /opt/homebrew/opt/llvm@20
LLVM_SYS_201_PREFIX: /opt/homebrew/opt/llvm@20
TABLEGEN_200_PREFIX: /opt/homebrew/opt/llvm@20
RUST_LOG: cairo_native=debug,cairo_native_test=debug
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -199,9 +199,9 @@ jobs:
- partition: 4
output: lcov-4.info
env:
MLIR_SYS_190_PREFIX: /usr/lib/llvm-19/
LLVM_SYS_191_PREFIX: /usr/lib/llvm-19/
TABLEGEN_190_PREFIX: /usr/lib/llvm-19/
MLIR_SYS_200_PREFIX: /usr/lib/llvm-20/
LLVM_SYS_201_PREFIX: /usr/lib/llvm-20/
TABLEGEN_200_PREFIX: /usr/lib/llvm-20/
RUST_LOG: cairo_native=debug
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -231,11 +231,11 @@ jobs:
- name: add llvm deb repository
uses: myci-actions/add-deb-repo@11
with:
repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-19 main
repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-20 main
repo-name: llvm-repo
keys-asc: https://apt.llvm.org/llvm-snapshot.gpg.key
- name: Install LLVM
run: sudo apt-get install llvm-19 llvm-19-dev llvm-19-runtime clang-19 clang-tools-19 lld-19 libpolly-19-dev libmlir-19-dev mlir-19-tools
run: sudo apt-get install llvm-20 llvm-20-dev llvm-20-runtime clang-20 clang-tools-20 lld-20 libpolly-20-dev libmlir-20-dev mlir-20-tools
- name: Install testing tools
uses: taiki-e/install-action@v2
with:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/daily.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ jobs:
run:
runs-on: ubuntu-latest
env:
LLVM_SYS_191_PREFIX: /usr/lib/llvm-19/
MLIR_SYS_190_PREFIX: /usr/lib/llvm-19/
TABLEGEN_190_PREFIX: /usr/lib/llvm-19/
LLVM_SYS_201_PREFIX: /usr/lib/llvm-20/
MLIR_SYS_200_PREFIX: /usr/lib/llvm-20/
TABLEGEN_200_PREFIX: /usr/lib/llvm-20/
RPC_ENDPOINT_TESTNET: ${{ secrets.RPC_ENDPOINT_TESTNET }}
RPC_ENDPOINT_MAINNET: ${{ secrets.RPC_ENDPOINT_MAINNET }}
strategy:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ jobs:
release:
runs-on: ubuntu-24.04
env:
MLIR_SYS_190_PREFIX: /usr/lib/llvm-19/
LLVM_SYS_191_PREFIX: /usr/lib/llvm-19/
TABLEGEN_190_PREFIX: /usr/lib/llvm-19/
MLIR_SYS_200_PREFIX: /usr/lib/llvm-20/
LLVM_SYS_201_PREFIX: /usr/lib/llvm-20/
TABLEGEN_200_PREFIX: /usr/lib/llvm-20/
CRATES_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }}
steps:
- name: Checkout
Expand All @@ -32,11 +32,11 @@ jobs:
- name: add llvm deb repository
uses: myci-actions/add-deb-repo@11
with:
repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-19 main
repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-20 main
repo-name: llvm-repo
keys-asc: https://apt.llvm.org/llvm-snapshot.gpg.key
- name: Install LLVM
run: sudo apt-get install llvm-19 llvm-19-dev llvm-19-runtime clang-19 clang-tools-19 lld-19 libpolly-19-dev libmlir-19-dev mlir-19-tools
run: sudo apt-get install llvm-20 llvm-20-dev llvm-20-runtime clang-20 clang-tools-20 lld-20 libpolly-20-dev libmlir-20-dev mlir-20-tools
- name: publish sierra emu
run: cargo publish --token ${CRATES_TOKEN} --all-features -p sierra-emu
- name: publish cairo native
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,18 @@ jobs:
include:
- target: x86_64-unknown-linux-gnu
os: ubuntu-24.04
dep_base_dir: /usr/lib/llvm-19
dep_base_dir: /usr/lib/llvm-20
- target: x86_64-apple-darwin
os: macos-14
dep_base_dir: /opt/homebrew/opt/llvm@19
dep_base_dir: /opt/homebrew/opt/llvm@20
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
- name: Set env
run: |
echo "MLIR_SYS_190_PREFIX=${{ matrix.dep_base_dir }}" >> $GITHUB_ENV
echo "LLVM_SYS_191_PREFIX=${{ matrix.dep_base_dir }}" >> $GITHUB_ENV
echo "TABLEGEN_190_PREFIX=${{ matrix.dep_base_dir }}" >> $GITHUB_ENV
echo "MLIR_SYS_200_PREFIX=${{ matrix.dep_base_dir }}" >> $GITHUB_ENV
echo "LLVM_SYS_201_PREFIX=${{ matrix.dep_base_dir }}" >> $GITHUB_ENV
echo "TABLEGEN_200_PREFIX=${{ matrix.dep_base_dir }}" >> $GITHUB_ENV
- name: Install deps
# deps-ci-linux does nothing on macos so it works
run: make deps && make deps-ci-linux
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/rustdoc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,21 @@ jobs:
name: GitHub Pages
runs-on: ubuntu-24.04
env:
MLIR_SYS_190_PREFIX: /usr/lib/llvm-19/
LLVM_SYS_191_PREFIX: /usr/lib/llvm-19/
TABLEGEN_190_PREFIX: /usr/lib/llvm-19/
MLIR_SYS_200_PREFIX: /usr/lib/llvm-20/
LLVM_SYS_201_PREFIX: /usr/lib/llvm-20/
TABLEGEN_200_PREFIX: /usr/lib/llvm-20/
steps:
- uses: actions/checkout@v4
- uses: dtolnay/[email protected]
- uses: Swatinem/rust-cache@v2
- name: add llvm deb repository
uses: myci-actions/add-deb-repo@11
with:
repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-19 main
repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-20 main
repo-name: llvm-repo
keys-asc: https://apt.llvm.org/llvm-snapshot.gpg.key
- name: Install LLVM
run: sudo apt-get install llvm-19 llvm-19-dev llvm-19-runtime clang-19 clang-tools-19 lld-19 libpolly-19-dev libmlir-19-dev mlir-19-tools
run: sudo apt-get install llvm-20 llvm-20-dev llvm-20-runtime clang-20 clang-tools-20 lld-20 libpolly-20-dev libmlir-20-dev mlir-20-tools
- name: Build docs
run: make doc
- name: Deploy Documentation
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/starknet-blocks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ jobs:
name: Run Blocks
runs-on: ubuntu-latest
env:
MLIR_SYS_190_PREFIX: /usr/lib/llvm-19/
LLVM_SYS_191_PREFIX: /usr/lib/llvm-19/
TABLEGEN_190_PREFIX: /usr/lib/llvm-19/
MLIR_SYS_200_PREFIX: /usr/lib/llvm-20/
LLVM_SYS_201_PREFIX: /usr/lib/llvm-20/
TABLEGEN_200_PREFIX: /usr/lib/llvm-20/
RPC_ENDPOINT_TESTNET: ${{ secrets.RPC_ENDPOINT_TESTNET }}
RPC_ENDPOINT_MAINNET: ${{ secrets.RPC_ENDPOINT_MAINNET }}
strategy:
Expand All @@ -32,8 +32,8 @@ jobs:
with:
repository: lambdaclass/starknet-replay
path: starknet-replay
# https://github.com/lambdaclass/starknet-replay/pull/185
ref: 9b9d486bdf9173a2bfd90d78f43ffb0ca2d27fcc
# https://github.com/lambdaclass/starknet-replay/pull/189
ref: 01d3161c40379764c19e7dbcdfe01fb683b7edf6
# We need native to use the linux deps ci action
- name: Checkout Native
uses: actions/checkout@v4
Expand All @@ -44,8 +44,8 @@ jobs:
with:
repository: lambdaclass/sequencer
path: sequencer
# https://github.com/lambdaclass/sequencer/pull/73
ref: fe5d445ad6da8bbbd82b044e9115add4aea910af
# https://github.com/lambdaclass/sequencer/pull/75
ref: 976f19b8304350290b761ed3448b8fdb8a620b0c
- name: Cache RPC Calls
uses: actions/[email protected]
with:
Expand Down
Loading
Loading