Skip to content

Conversation

@DiegoCivi
Copy link
Contributor

Implement Squashed Felt252 Dict Entries libfunc

Closes #1151

Introduces Breaking Changes?

Yes/No.

These PRs should be merged after this one right away, in that order.

Checklist

  • Linked to Github Issue.
  • Unit tests added.
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 2.36967% with 206 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.55%. Comparing base (1852943) to head (761757e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/libfuncs/squashed_dict.rs 0.00% 132 Missing ⚠️
src/metadata/runtime_bindings.rs 6.77% 55 Missing ⚠️
src/runtime.rs 0.00% 17 Missing ⚠️
src/libfuncs.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1446      +/-   ##
==========================================
- Coverage   81.45%   79.55%   -1.91%     
==========================================
  Files         105      108       +3     
  Lines       25862    26538     +676     
==========================================
+ Hits        21065    21111      +46     
- Misses       4797     5427     +630     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Benchmark results Main vs HEAD.

Base

Command Mean [s] Min [s] Max [s] Relative
base dict_insert.cairo (JIT) 2.521 ± 0.017 2.501 2.558 1.03 ± 0.01
base dict_insert.cairo (AOT) 2.436 ± 0.018 2.407 2.465 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head dict_insert.cairo (JIT) 2.503 ± 0.012 2.487 2.521 1.03 ± 0.01
head dict_insert.cairo (AOT) 2.419 ± 0.014 2.396 2.436 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base dict_snapshot.cairo (JIT) 2.238 ± 0.020 2.213 2.271 1.05 ± 0.01
base dict_snapshot.cairo (AOT) 2.126 ± 0.012 2.108 2.147 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head dict_snapshot.cairo (JIT) 2.223 ± 0.019 2.187 2.256 1.06 ± 0.01
head dict_snapshot.cairo (AOT) 2.105 ± 0.017 2.073 2.122 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 2.586 ± 0.012 2.563 2.604 1.01 ± 0.01
base factorial_2M.cairo (AOT) 2.561 ± 0.016 2.537 2.587 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 2.588 ± 0.017 2.556 2.608 1.02 ± 0.01
head factorial_2M.cairo (AOT) 2.541 ± 0.017 2.519 2.567 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 2.152 ± 0.023 2.125 2.184 1.03 ± 0.02
base fib_2M.cairo (AOT) 2.084 ± 0.021 2.058 2.134 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 2.144 ± 0.025 2.100 2.177 1.03 ± 0.01
head fib_2M.cairo (AOT) 2.092 ± 0.017 2.071 2.115 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base heavy_circuit.cairo (JIT) 13.855 ± 0.057 13.750 13.940 1.03 ± 0.00
base heavy_circuit.cairo (AOT) 13.455 ± 0.029 13.418 13.509 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head heavy_circuit.cairo (JIT) 13.848 ± 0.076 13.713 13.943 1.03 ± 0.01
head heavy_circuit.cairo (AOT) 13.505 ± 0.075 13.388 13.654 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base linear_search.cairo (JIT) 2.309 ± 0.017 2.286 2.338 1.06 ± 0.01
base linear_search.cairo (AOT) 2.171 ± 0.016 2.147 2.202 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head linear_search.cairo (JIT) 2.334 ± 0.022 2.295 2.361 1.07 ± 0.01
head linear_search.cairo (AOT) 2.186 ± 0.013 2.167 2.209 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 2.426 ± 0.016 2.408 2.462 1.08 ± 0.01
base logistic_map.cairo (AOT) 2.255 ± 0.015 2.231 2.278 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 2.423 ± 0.020 2.398 2.450 1.08 ± 0.01
head logistic_map.cairo (AOT) 2.246 ± 0.019 2.221 2.286 1.00

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Benchmarking results

Benchmark for program dict_insert

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.933 ± 0.068 10.812 11.039 4.44 ± 0.05
cairo-native (embedded AOT) 2.465 ± 0.020 2.425 2.496 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 2.545 ± 0.037 2.508 2.619 1.03 ± 0.02

Benchmark for program dict_snapshot

Open benchmarks
Command Mean [ms] Min [ms] Max [ms] Relative
Cairo-vm (Rust, Cairo 1) 534.4 ± 5.4 526.2 541.7 1.00
cairo-native (embedded AOT) 2211.8 ± 26.0 2187.8 2281.1 4.14 ± 0.06
cairo-native (embedded JIT using LLVM's ORC Engine) 2295.4 ± 13.6 2281.2 2326.0 4.30 ± 0.05

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.759 ± 0.038 4.728 4.853 1.82 ± 0.02
cairo-native (embedded AOT) 2.647 ± 0.059 2.560 2.733 1.01 ± 0.02
cairo-native (embedded JIT using LLVM's ORC Engine) 2.617 ± 0.013 2.593 2.632 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.721 ± 0.007 4.708 4.729 2.21 ± 0.02
cairo-native (embedded AOT) 2.163 ± 0.035 2.110 2.211 1.01 ± 0.02
cairo-native (embedded JIT using LLVM's ORC Engine) 2.135 ± 0.018 2.118 2.181 1.00

Benchmark for program heavy_circuit

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 9.619 ± 0.054 9.550 9.705 1.00
cairo-native (embedded AOT) 14.635 ± 0.078 14.554 14.777 1.52 ± 0.01
cairo-native (embedded JIT using LLVM's ORC Engine) 15.380 ± 0.096 15.185 15.538 1.60 ± 0.01

Benchmark for program linear_search

Open benchmarks
Command Mean [ms] Min [ms] Max [ms] Relative
Cairo-vm (Rust, Cairo 1) 580.8 ± 14.2 565.1 608.3 1.00
cairo-native (embedded AOT) 2267.5 ± 23.2 2231.4 2308.9 3.90 ± 0.10
cairo-native (embedded JIT using LLVM's ORC Engine) 2404.6 ± 27.8 2365.9 2456.4 4.14 ± 0.11

Benchmark for program logistic_map

Open benchmarks
Command Mean [ms] Min [ms] Max [ms] Relative
Cairo-vm (Rust, Cairo 1) 373.8 ± 5.1 367.6 385.7 1.00
cairo-native (embedded AOT) 2268.0 ± 31.7 2232.6 2314.3 6.07 ± 0.12
cairo-native (embedded JIT using LLVM's ORC Engine) 2434.7 ± 15.5 2410.8 2459.2 6.51 ± 0.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[2.11.1] Implement Squashed Felt252 Dict Entries Libfunc

3 participants