Skip to content

Update leanSpec commit to d39d101#215

Merged
pablodeymo merged 1 commit intomainfrom
update-lean-spec-commit
Mar 13, 2026
Merged

Update leanSpec commit to d39d101#215
pablodeymo merged 1 commit intomainfrom
update-lean-spec-commit

Conversation

@pablodeymo
Copy link
Collaborator

Summary

  • Bump LEAN_SPEC_COMMIT_HASH in Makefile from 8b7636b to d39d101

Test plan

  • rm -rf leanSpec && make leanSpec/fixtures succeeds with the new commit
  • make test passes with regenerated fixtures

@github-actions
Copy link

🤖 Kimi Code Review

⚠️ Review failed: Kimi API request failed with status 429


Automated review by Kimi (Moonshot AI)

@github-actions
Copy link

🤖 Codex Code Review

  1. No correctness/security/performance findings in this PR diff.
    Only change is a leanSpec pin update at Makefile.

  2. Residual risk: this is a supply-chain/input-change update, so behavior can still shift indirectly via generated fixtures/spec alignment even without Rust code changes.
    Relevant lines: Makefile, Makefile, Makefile.

Recommended validation before merge:

  1. Regenerate fixtures with the new leanSpec commit and run full consensus/state-transition tests.
  2. Confirm fork-choice/attestation/finalization test vectors are unchanged or intentionally updated.

Automated review by OpenAI Codex · custom prompt

@pablodeymo pablodeymo merged commit f943daf into main Mar 13, 2026
7 checks passed
@pablodeymo pablodeymo deleted the update-lean-spec-commit branch March 13, 2026 18:45
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 13, 2026

Greptile Summary

This PR updates the pinned LEAN_SPEC_COMMIT_HASH in the Makefile from 8b7636bb8a95fe4bec414cc4c24e74079e6256b6 to d39d10195414921e979e2fdd43723d89cee13c8b, tracking the latest commit in the leanEthereum/leanSpec repository used for generating test fixtures.

  • The change is a single-line bump of the pinned external dependency commit hash.
  • The fixture generation workflow (git clone + git checkout <hash> + uv run fill) is unchanged.
  • The test plan in the PR description appropriately calls for regenerating fixtures (rm -rf leanSpec && make leanSpec/fixtures) and running the full test suite (make test) to verify compatibility with the new commit.

Confidence Score: 5/5

  • This PR is safe to merge once the test plan checklist is confirmed green.
  • The change is a trivial one-line dependency hash bump with no modifications to build logic, APIs, or runtime behavior. The risk is bounded entirely by whether the new leanSpec commit is compatible, which the listed manual test steps directly verify.
  • No files require special attention.

Important Files Changed

Filename Overview
Makefile Bumps LEAN_SPEC_COMMIT_HASH from 8b7636bb... to d39d1019...; no structural changes to the Makefile logic.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["make test"] --> B["leanSpec/fixtures (prerequisite)"]
    B --> C["leanSpec (prerequisite)"]
    C --> D["git clone leanEthereum/leanSpec\n--single-branch"]
    D --> E["git checkout d39d10195414921e979e2fdd43723d89cee13c8b\n(updated from 8b7636bb...)"]
    E --> F["uv run fill --fork devnet --scheme=prod -o fixtures"]
    F --> G["cargo test --workspace --release"]
Loading

Last reviewed commit: ff0a710

@github-actions
Copy link

🤖 Claude Code Review

Based on the PR diff, here is my review:


Review: Update leanSpec commit to d39d101

Change: Makefile — bump LEAN_SPEC_COMMIT_HASH from 8b7636bb... to d39d1019... (1 line changed)


Summary

This is a minimal, mechanical change. The diff is correct and well-formed.

Positives:

  • Full 40-character commit hash used — no ambiguity with short hashes.
  • PR description clearly states what changed and why.
  • Test plan is appropriate: regenerate fixtures and run make test against them.

Concerns

Spec changes not reviewed here. The commit bump itself is fine, but the content of the leanSpec delta between 8b7636b and d39d101 is what actually matters for correctness. The review checklist in the PR body (rm -rf leanSpec && make leanSpec/fixtures + make test) is the right gate — but this should be confirmed as actually completed before merging, not just listed as a to-do. The checkboxes in the PR body are unchecked at time of review.

Recommendation: Confirm that the test plan items have been executed and passed (or add a CI check that covers it). If the spec update includes changes to fork choice, STF, or attestation behavior, those changes warrant a closer look at the corresponding leanSpec diff before merging.


Verdict

The Makefile change is correct. Merge contingent on the test plan being verified — particularly that make test passes with regenerated fixtures against the new spec commit.


Automated review by Claude (Anthropic) · custom prompt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants