Skip to content

Increase STATES_TO_KEEP from 900 to 3000 #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablodeymo merged 3 commits into from
Mar 17, 2026
Merged

Increase STATES_TO_KEEP from 900 to 3000 #241

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
637b131
Increase STATES_TO_KEEP from 900 to 3000
pablodeymo Mar 17, 2026
cadd3f6
Fixing comment in test
pablodeymo Mar 17, 2026
e66d980
Apply suggestion from @MegaRedHand
pablodeymo Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions crates/storage/src/store.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ const KEY_LATEST_FINALIZED: &[u8] = b"latest_finalized";
/// ~1 day of block history at 4-second slots (86400 / 4 = 21600).
const BLOCKS_TO_KEEP: usize = 21_600;

/// ~1 hour of state history at 4-second slots (3600 / 4 = 900).
const STATES_TO_KEEP: usize = 900;
/// ~3.3 hours of state history at 4-second slots (12000 / 4 = 3000).
const STATES_TO_KEEP: usize = 3_000;

const _: () = assert!(
BLOCKS_TO_KEEP >= STATES_TO_KEEP,
Expand Down Expand Up @@ -1486,9 +1486,9 @@ mod tests {
let head_root = root(total_states as u64 - 1);
store.update_checkpoints(ForkCheckpoints::head_only(head_root));

// 905 headers total. Top 900 by slot are kept in the retention window,
// 3005 headers total. Top 3000 by slot are kept in the retention window,
// leaving 5 candidates. 2 are protected (finalized + justified),
// so 3 are pruned → 905 - 3 = 902 states remaining.
// so 3 are pruned → 3005 - 3 = 3002 states remaining.
assert_eq!(
count_entries(backend.as_ref(), Table::States),
STATES_TO_KEEP + 2
Expand Down
Loading