Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(l1): remove --import and --import_dir #2177

Merged
merged 4 commits into from
Mar 7, 2025
Merged

chore(l1): remove --import and --import_dir #2177

merged 4 commits into from
Mar 7, 2025
+10 −53

Conversation

LeanSerra
Copy link
Contributor

@LeanSerra LeanSerra commented Mar 7, 2025 •
edited
Loading

Motivation

The arguments --import and --import_dir were left over because the hive fork was not updated

Description

  • Remove arguments --import and --import_dir from cli

Closes #2122

LeanSerra added 2 commits March 7, 2025 12:35
@LeanSerra
remove --import and --import_dir

Verified

This commit was signed with the committer’s verified signature.
LeanSerra
SSH Key Fingerprint: jYQxLfh6r7VIYHI8wQlQ0v7QJuVLRCi2rUVNKvAZvYQ
Verified
Learn about vigilant mode
bc07578
@LeanSerra
remove arguments from cli

Verified

This commit was signed with the committer’s verified signature.
LeanSerra
SSH Key Fingerprint: jYQxLfh6r7VIYHI8wQlQ0v7QJuVLRCi2rUVNKvAZvYQ
Verified
Learn about vigilant mode
Loading
Loading status checks…
a7ff0b5
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

Lines of code report

Total lines added: 2
Total lines removed: 40
Total lines changed: 42

Detailed view 
+-----------------------------------------+-------+------+
| File                                    | Lines | Diff |
+-----------------------------------------+-------+------+
| ethrex/cmd/ethrex/cli.rs                | 188   | -12  |
+-----------------------------------------+-------+------+
| ethrex/cmd/ethrex/initializers.rs       | 348   | -28  |
+-----------------------------------------+-------+------+
| ethrex/cmd/ethrex/subcommands/import.rs | 43    | +2   |
+-----------------------------------------+-------+------+

@LeanSerra
change hive branch just to test ci should be reverted to master

Verified

This commit was signed with the committer’s verified signature.
LeanSerra
SSH Key Fingerprint: jYQxLfh6r7VIYHI8wQlQ0v7QJuVLRCi2rUVNKvAZvYQ
Verified
Learn about vigilant mode
Loading
Loading status checks…
b0be349
@LeanSerra LeanSerra self-assigned this Mar 7, 2025
@LeanSerra LeanSerra added cli Command line interface L1 Ethereum client labels Mar 7, 2025
@LeanSerra LeanSerra mentioned this pull request Mar 7, 2025
Closed
@LeanSerra LeanSerra changed the title chore(l1) remove --import and --import_dir chore(l1): remove --import and --import_dir Mar 7, 2025
@LeanSerra
revert changes from previous commit, change hive revision to new hash

Verified

This commit was signed with the committer’s verified signature.
LeanSerra
SSH Key Fingerprint: jYQxLfh6r7VIYHI8wQlQ0v7QJuVLRCi2rUVNKvAZvYQ
Verified
Learn about vigilant mode
Loading
Loading status checks…
f93f01b
@LeanSerra LeanSerra marked this pull request as ready for review March 7, 2025 16:23
@LeanSerra LeanSerra requested a review from a team as a code owner March 7, 2025 16:23
@jrchatruc jrchatruc added this pull request to the merge queue Mar 7, 2025
Merged via the queue into main with commit 49b5efe Mar 7, 2025
20 checks passed
@jrchatruc jrchatruc deleted the l1/remove_import branch March 7, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpaulucci mpaulucci

@jrchatruc jrchatruc

Assignees

@LeanSerra LeanSerra

Labels
cli Command line interface L1 Ethereum client
Projects
ethrex_l1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace --import option with import subcommand.
3 participants
@LeanSerra @mpaulucci @jrchatruc