-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): further decouple LEVM and rEVM implementations. #2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpaulucci
commented
Mar 7, 2025
mpaulucci
commented
Mar 7, 2025
mpaulucci
commented
Mar 7, 2025
mpaulucci
commented
Mar 7, 2025
mpaulucci
commented
Mar 7, 2025
…to decouple-levm-revm-2
Lines of code reportTotal lines added: Detailed view
|
fkrause98
approved these changes
Mar 7, 2025
JereSalo
reviewed
Mar 7, 2025
JereSalo
approved these changes
Mar 7, 2025
ilitteri
reviewed
Mar 7, 2025
This was referenced Mar 10, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 14, 2025
**Motivation** - When executing ethereum/rpc simulation with LEVM we have errors in a lot of tests. The error is when executing the blocks for the setup for these tests and how we created the withdrawals requests introduced in EIP-7002 **Description** - First, when we execute the transactions, we weren't handling if the account was delegated and we weren't using the correct bytecode. For this, we add the check for delegated accounts and get the bytecode. This is made when creating a new VM and using the function `eip7702_get_code()`. - Second, when creating the withdrawals requests, we were overwritting and loosing some of the new values in the account updates. We now merge both updates. - When running the system contract for the withdrawals requests introduced in EIP 7002, we were creating a new `CacheDB` instead of using the one with updated values. **Status** - All RPC Hive tests were passing, but with the changed made [here](#2179), 12 are failing due to a new missing implementation. Links to #2158 --------- Co-authored-by: Tomás Paradelo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Separate code from LEVM and rEVM implementations and try not to expose rEVM specific logic outside of vm crate.
Description
backends/levm/...
backens/revm/...