Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(levm): simplify fill_with_zeros #2226

Merged
merged 3 commits into from
Mar 17, 2025
Merged

refactor(levm): simplify fill_with_zeros #2226

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b8e10c
refactor: simplify fill_with_zeros
Oppen Mar 13, 2025
294a2cc
Merge branch 'main' into refactor/cleaner_padding
Oppen Mar 14, 2025
4ada4b3
Merge branch 'main' into refactor/cleaner_padding
Oppen Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions crates/vm/levm/src/precompiles.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,15 +300,12 @@ fn increase_precompile_consumed_gas(

/// When slice length is less than 128, the rest is filled with zeros. If slice length is
/// more than 128 the excess bytes are discarded.
fn fill_with_zeros(calldata: &Bytes, target_len: usize) -> Result<Bytes, VMError> {
fn fill_with_zeros(calldata: &Bytes, target_len: usize) -> Bytes {
let mut padded_calldata = calldata.to_vec();
if padded_calldata.len() < target_len {
let size_diff = target_len
.checked_sub(padded_calldata.len())
.ok_or(InternalError::ArithmeticOperationUnderflow)?;
padded_calldata.extend(vec![0u8; size_diff]);
padded_calldata.resize(target_len, 0);
}
Ok(padded_calldata.into())
padded_calldata.into()
}

/// ECDSA (Elliptic curve digital signature algorithm) public key recovery function.
Expand All @@ -323,7 +320,7 @@ pub fn ecrecover(
increase_precompile_consumed_gas(gas_for_call, gas_cost, consumed_gas)?;

// If calldata does not reach the required length, we should fill the rest with zeros
let calldata = fill_with_zeros(calldata, 128)?;
let calldata = fill_with_zeros(calldata, 128);

// Parse the input elements, first as a slice of bytes and then as an specific type of the crate
let hash = calldata.get(0..32).ok_or(InternalError::SlicingError)?;
Expand Down Expand Up @@ -422,7 +419,7 @@ pub fn modexp(
fork: Fork,
) -> Result<Bytes, VMError> {
// If calldata does not reach the required length, we should fill the rest with zeros
let calldata = fill_with_zeros(calldata, 96)?;
let calldata = fill_with_zeros(calldata, 96);

let base_size = U256::from_big_endian(
calldata
Expand Down Expand Up @@ -556,7 +553,7 @@ pub fn ecadd(
fork: Fork,
) -> Result<Bytes, VMError> {
// If calldata does not reach the required length, we should fill the rest with zeros
let calldata = fill_with_zeros(calldata, 128)?;
let calldata = fill_with_zeros(calldata, 128);
// https://eips.ethereum.org/EIPS/eip-1108
let gas_cost = if fork < Fork::Istanbul {
ECADD_COST_PRE_ISTANBUL
Expand Down Expand Up @@ -642,7 +639,7 @@ pub fn ecmul(
fork: Fork,
) -> Result<Bytes, VMError> {
// If calldata does not reach the required length, we should fill the rest with zeros
let calldata = fill_with_zeros(calldata, 96)?;
let calldata = fill_with_zeros(calldata, 96);
// https://eips.ethereum.org/EIPS/eip-1108
let gas_cost = if fork < Fork::Istanbul {
ECMUL_COST_PRE_ISTANBUL
Expand Down
Loading