You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
Seems more straight-forward than the enum, i think i prefer this approach. However, i'm not sure if an Arc is the best way to handle the StoreWrapper: Arc::new(store_wrapper.clone()), seems to be, but i would wait for someone with more experience.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR exists to use LEVM as the EVM for executing SP1 prover
Description
LevmDatabase
for theExecutionDb
.get_chain_config()
for theLevmDatabase
trait.ExecutionDb
to a common place and remove from some of REVM dependencies. But, there are some left to be removed in the next PR.levm-l2
for choosing whether to execute the Prover and the ExecutionDb with LEVM or not.Status
Links to #2225