Skip to content

refactor(l1, l2): metrics folder #3346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 18, 2025
Merged

refactor(l1, l2): metrics folder #3346

merged 8 commits into from
Jul 18, 2025

Conversation

SDartayet
Copy link
Contributor

@SDartayet SDartayet commented Jun 26, 2025 •
edited
Loading

Motivation

Having all our metrics dashboards in one folder, so it's all better organized.

Description

This PR moves all the dashboards and yaml files needed to set up the Prometheus and Grafana containers into one folder at the root.

Closes #3181

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2025 •
edited
Loading

Lines of code report

Total lines added: 1098
Total lines removed: 288
Total lines changed: 1386

Detailed view 
+------------------------------------------------------------------------+-------+------+
| File                                                                   | Lines | Diff |
+------------------------------------------------------------------------+-------+------+
| ethrex/cmd/ethrex/ethrex.rs                                            | 139   | +8   |
+------------------------------------------------------------------------+-------+------+
| ethrex/cmd/ethrex/initializers.rs                                      | 339   | +54  |
+------------------------------------------------------------------------+-------+------+
| ethrex/cmd/ethrex/l2/mod.rs                                            | 7     | -1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/cmd/ethrex/networks.rs                                          | 91    | -17  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/common/common.rs                                         | 8     | -1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/common/src/lib.rs                                     | 3     | -2   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/prover/src/backends/exec.rs                           | 37    | -2   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/prover/src/prover.rs                                  | 116   | +1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/prover/zkvm/interface/src/execution.rs                | 338   | +1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/prover/zkvm/interface/src/io.rs                       | 78    | -1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/sdk/src/calldata.rs                                   | 582   | +13  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/sdk/src/l1_to_l2_tx_data.rs                           | 67    | -1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/sdk/src/sdk.rs                                        | 512   | -1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/block_producer/payload_builder.rs           | 327   | +13  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/errors.rs                                   | 278   | +3   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/l1_committer.rs                             | 543   | -1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/l1_proof_sender.rs                          | 297   | -17  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/l1_proof_verifier.rs                        | 164   | -16  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/mod.rs                                      | 153   | -4   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/proof_coordinator.rs                        | 495   | -8   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/setup.rs                                    | 98    | -1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/storage/src/api.rs                                    | 84    | -12  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/storage/src/store.rs                                  | 286   | -20  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/storage/src/store_db/in_memory.rs                     | 217   | -24  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/storage/src/store_db/libmdbx.rs                       | 320   | -26  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/storage/src/store_db/redb.rs                          | 317   | -32  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/storage/src/store_db/sql.rs                           | 476   | -48  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/tee/quote-gen/src/main.rs                             | 101   | -3   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/tee/quote-gen/src/sender.rs                           | 74    | +2   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/utils/mod.rs                                          | 4     | +1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/utils/prover/errors.rs                                | 13    | +13  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/utils/prover/mod.rs                                   | 3     | +3   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/utils/prover/proving_systems.rs                       | 104   | +104 |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/l2/utils/prover/save_state.rs                            | 419   | +419 |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/kademlia.rs                               | 613   | -1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/eth/transaction.rs                        | 590   | +17  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/l2/l1_message.rs                          | 88    | +88  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/l2/mod.rs                                 | 2     | +2   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/l2/transaction.rs                         | 222   | +222 |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/lib.rs                                    | 15    | -9   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/rpc.rs                                    | 589   | +42  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/utils.rs                                  | 378   | +58  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/call_frame.rs                                | 251   | +2   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/debug.rs                                     | 42    | -1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/execution_handlers.rs                        | 226   | -26  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/opcode_handlers/block.rs                     | 125   | -1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/opcode_handlers/push.rs                      | 78    | +32  |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/opcode_handlers/stack_memory_storage_flow.rs | 258   | -8   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/precompiles.rs                               | 1270  | -2   |
+------------------------------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/utils.rs                                     | 441   | -1   |
+------------------------------------------------------------------------+-------+------+
| ethrex/tooling/load_test/src/main.rs                                   | 365   | -1   |
+------------------------------------------------------------------------+-------+------+

mpaulucci
mpaulucci requested changes Jul 1, 2025
View reviewed changes
Copy link
Collaborator

@mpaulucci mpaulucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why metrics/metrics?

@SDartayet SDartayet marked this pull request as ready for review July 8, 2025 14:52
@SDartayet SDartayet requested a review from a team as a code owner July 8, 2025 14:52
@github-actions github-actions bot added L1 Ethereum client L2 Rollup client labels Jul 8, 2025
@SDartayet
Copy link
Contributor Author

why metrics/metrics?

That was accidental, sorry. Fixed here!

@ilitteri ilitteri moved this to In Review in ethrex_l2 Jul 8, 2025
@mpaulucci mpaulucci removed this from ethrex_l2 Jul 8, 2025
@mpaulucci mpaulucci moved this to In Review in ethrex_l1 Jul 8, 2025
cdiielsi
cdiielsi approved these changes Jul 10, 2025
View reviewed changes
Copy link
Contributor

@cdiielsi cdiielsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SDartayet SDartayet changed the title refactor(core): metrics folder refactor(l1, l2): metrics folder Jul 14, 2025
@SDartayet SDartayet added this pull request to the merge queue Jul 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jul 14, 2025
@SDartayet SDartayet enabled auto-merge July 17, 2025 20:03
@SDartayet SDartayet added this pull request to the merge queue Jul 18, 2025
Merged via the queue into main with commit b38493e Jul 18, 2025
39 checks passed
@SDartayet SDartayet deleted the metrics-folder branch July 18, 2025 09:10
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpaulucci mpaulucci mpaulucci approved these changes

@cdiielsi cdiielsi cdiielsi approved these changes

Assignees

@SDartayet SDartayet

Labels
L1 Ethereum client L2 Rollup client
Projects
ethrex_l1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move metrics dashboard outside of the crates folder
3 participants
@SDartayet @mpaulucci @cdiielsi