Skip to content

refactor(core): remove l2 feature from cmd/ethrex achieving a single binary for both L1 and L2 #3381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 47 commits into
base: main
Choose a base branch
from
Open

refactor(core): remove l2 feature from cmd/ethrex achieving a single binary for both L1 and L2 #3381

wants to merge 47 commits into from
+16 −29

Conversation

ilitteri
Copy link
Contributor

Warning

Merge after #3371

Motivation

We want ethrex to be a single binary for both running L1 and L2. For this, we need to remove the l2 feature flag from cmd/ethrex, a work that includes removing the same feature flag from the following crates:

  1. ethrex-vm.
  2. ethrex-levm.
  3. ethrex-blockchain.

1 and 2 are removed in #3367, and 3 is removed in #3371.

Description

Removes l2 feature flag from cmd/ethrex

ilitteri and others added 30 commits June 25, 2025 23:20
@ilitteri
Add ethrex-l2-rpc crate
b8b3e3e
@ilitteri
Remove feature l2 from rpc crate
c851fba
@ilitteri
Move init_rollup_store to l2::initializers
9920eaf
@ilitteri
Remove last piece of l2 code from rpc crate
2aab6db 
TODO: Reject blob transactions in L2
@ilitteri
Add a TODO
0faf575
@ilitteri
Reject blob transactions in l2
721479a
@ilitteri
Clean dead code
aa40204
@ilitteri
Add clippy allow
56fd63e
@ilitteri
Fix lint
6feefca
@ilitteri
Fix lint
87ccd57
@ilitteri
Remove type aliases
6637c1c
@ilitteri
Use namespace instead of import aliasing
26d3bf7
@ilitteri
Refactor
4d14da5
@ilitteri
Replace allow with expect for clippy lint
cb573d2
@ilitteri
Remove unused imports
1c87759
@ilitteri
Move l2 precompiles logic to new module
28843a6
@ilitteri
Remove feature flag from hooks public API
39a509f
@ilitteri
Use the correct functions
3023b88
@ilitteri
Replace get_hooks
88bc9a2
@ilitteri
Remove l2 feature flag from levm
8b09883
@ilitteri
Remove l2 feature flag from vm crate
fd971be
@ilitteri
Implement BlockchainType and fix compilation
32557eb
@ilitteri
Merge branch 'main' of github.com:lambdaclass/ethrex into remove_l2_f…
137ca29 
…eature_flag_from_levm
@ilitteri
Fix l2 command
1fe36d4
@ilitteri
Remove last occurrences of ethrex-vm/l2 import
cda4244
@ilitteri
Fix p_256_verify_test
0860942
@ilitteri
Update crates/vm/backends/revm/mod.rs
1c7f2a5
@ilitteri
Fix stateless execution
68d0524
@ilitteri
Update crates/vm/levm/bench/revm_comparison/src/levm_bench.rs
93efc4a
@ilitteri
Fix stateless execution
7841613
@ilitteri ilitteri self-assigned this Jun 27, 2025
@ilitteri ilitteri requested a review from a team as a code owner June 27, 2025 22:33
@ilitteri ilitteri added L2 Rollup client cli Command line interface L1 Ethereum client simplification Any refactor that makes code simpler and more straight forward labels Jun 27, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 27, 2025 •
edited
Loading

Lines of code report

Total lines added: 0
Total lines removed: 6
Total lines changed: 6

Detailed view 
+----------------------------+-------+------+
| File                       | Lines | Diff |
+----------------------------+-------+------+
| ethrex/cmd/ethrex/cli.rs   | 451   | -3   |
+----------------------------+-------+------+
| ethrex/cmd/ethrex/lib.rs   | 8     | -1   |
+----------------------------+-------+------+
| ethrex/cmd/ethrex/utils.rs | 143   | -2   |
+----------------------------+-------+------+

MegaRedHand
MegaRedHand approved these changes Jun 30, 2025
View reviewed changes
Copy link
Collaborator

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilitteri ilitteri requested review from juanbono, jrchatruc and a team June 30, 2025 19:58
@ilitteri
Merge branch 'remove_l2_feature_flag_from_blockchain' of github.com:l…
2bc3534 
…ambdaclass/ethrex into remove_l2_feature_from_cmd_ethrex
@MegaRedHand MegaRedHand moved this to In Review in ethrex_l2 Jul 1, 2025
@LeanSerra LeanSerra mentioned this pull request Jul 1, 2025
Draft
@MegaRedHand MegaRedHand moved this from In Review to Queued in ethrex_l2 Jul 2, 2025
Base automatically changed from remove_l2_feature_flag_from_blockchain to main July 2, 2025 18:06
@MegaRedHand MegaRedHand enabled auto-merge July 2, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MegaRedHand MegaRedHand MegaRedHand approved these changes

@jrchatruc jrchatruc jrchatruc approved these changes

@juanbono juanbono Awaiting requested review from juanbono

Assignees

@ilitteri ilitteri

Labels
cli Command line interface L1 Ethereum client L2 Rollup client simplification Any refactor that makes code simpler and more straight forward
Projects
ethrex_l2
Status: Queued
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilitteri @MegaRedHand @jrchatruc